550445 - DirectWrite nsIFontEnumerator.EnumerateFonts needs to recognize aGeneric

Status: NEW

(Core :: Layout: Text and Fonts, defect)

Description

[Rain [:rain1] (inactive)]

fe = Components.classes["@mozilla.org/gfx/fontenumerator;1"].createInstance(Components.interfaces.nsIFontEnumerator); fe.EnumerateFonts("x-western", "serif", {})

returns all fonts, whether serif, non-serif or monospace. Only serif fonts are returned with GDI. (This causes the font chooser to be populated with all sorts of fonts for each style.)

Comment 1

[Jonathan Kew [:jfkthame]]

This is because gfxDWriteFontEntry does not implement the MatchesGenericFamily method, so it falls back to the base implementation in gfxFontEntry, which always answers "yes".

Comment 2

[David Baron :dbaron:]

Could this explain a bunch of the reftest failures in bug 549832 where serif/sans-serif fonts got crossed?

Comment 3

[Mime Čuvalo]

This happens for me and I think DirectWrite is disabled (at least it says so in about:support).  Related to bug 107888?