550484 - Hardcoded widths for pref-proxies-advanced and pref-languages.add dialogs

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Michael Wolf]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; hsb-DE; rv:1.8.1.23) Gecko/20090825 SeaMonkey/1.1.18
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; hsb-DE; rv:1.8.1.23) Gecko/20090825 SeaMonkey/1.1.18

The dialog boxes are too narrow. They and - unfortunately a lot of other dialog boxes - have been hardcoded. I don't know why widths are still hardcoded after so many years of localizing Mozilla builds. All dialog boxes should generally be customizable for localizers. I don't understand why that is over and over again ignored. In the two cases I mentioned the width is even defined by a fixed number of *characters*! Different languages have differently long words! In pref-proxies-advanded.xul a width of "54ch" is defined and in pref-languages-add.xul a width of "41ch". A width in *em* has at least a certain margin but a width in *characters* is nonsense! It's only valid for English! I'm sure there are a lot of bugs where is complained about too small widths and heights. They all wouldn't exist if widths and heights wouldn't be hardcoded!

Please make at least the widths and heights of these two dialog boxes customizable for localizers. 

Reproducible: Always

Actual Results:  
In Upper Sorbian the dialog boxes for Preferences --> Advanced --> Proxies --> Advanced and Preferences --> Navigator --> Languages --> Add are too narrow.

Expected Results:  
Dialog boxes should be customizable that text is fully readable in them.

Comment 1

[lenochod]

SeaMonkey 1.1 will only accept security and stability (crashes) fixes.

Reporter, can you try and reproduce with SeaMonkey v2.0.3 ?

Comment 2

[therube]

Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110511 Firefox/4.0.1 SeaMonkey/2.1

I'll confirm that the 'Advanced Proxy Preferences' dialog window is not resizable.

In FF4 - FF6 (they call the window 'Connection Settings') it is also not resizeable.

Comment 3

[Ian Neal]

Attachment: Add ability to localise pref-proxies-advanced and pref-languages.add dialogs patch v1.0

This patch:
* Adds entities for the style for the two dialogs.
* Uses the new entities to style the two dialogs.

Comment 4

[[e-mail]]

(In reply to comment #0)
> A width in *em* has
> at least a certain margin but a width in *characters* is nonsense!
Since em is a height unit, a width in em is nonsense...

The strings in the dialogs should all wrap as appropriate. (Indeed, in the proxy dialog, some of them already wrap in English.) Of course there may be something that I'm overlooking, but I'd need a screenshot of the problem.

Comment 5

[Ian Neal]

Attachment: Polish add languages dialog

Shows the other field being too narrow.

Comment 6

[Ian Neal]

Attachment: Norwegian advanced proxies dialog

This is the Norwegian advanced proxies dialog, ip fields are smaller than they should be.

There are similar issues with the Slovakian and Lithuanian ones.

Comment 7

[[e-mail]]

Comment on attachment 533389 [details] [diff] [review]
Add ability to localise pref-proxies-advanced and pref-languages.add dialogs patch v1.0

>-            style="width: 41ch; height: 28em;">
We can probably do without this style and just let the dialog size itself.

>-            style="width: 54ch;"
Your screenshot doesn't seem to show a problem...

Comment 8

[[e-mail]]

(In reply to comment #7)
>(From update of attachment 533389 [details] [diff] [review])
>>-            style="width: 41ch; height: 28em;">
>We can probably do without this style and just let the dialog size itself.
> 
>>-            style="width: 54ch;"
>Your screenshot doesn't seem to show a problem...
Actually on both cases removing the style isn't quite the correct fix, you also need to set style="width: 1px;" on the descriptions to get them to wrap. (And the add languages dialog becomes narrower in English, probably caused by the size on the textbox being too low.)

Comment 9

[Ian Neal]

Attachment: With main styles removed, description styles added and textbox size increased [Checked in: Comment 11]

Changes since last version (as suggested by reviewer):
* Just remove the style from prefwindows.
* Add style to each description element.
* Increase size of add-language textbox.

Comment 10

[[e-mail]]

Comment on attachment 551506 [details] [diff] [review]
With main styles removed, description styles added and textbox size increased [Checked in: Comment 11]

Interestingly this now makes the listbox size to the width for the longest language, which is apparently "Macedonian/Macedonia, F.Y.R. of  [mk/mk]"

Comment 11

[Ian Neal]

Comment on attachment 551506 [details] [diff] [review]
With main styles removed, description styles added and textbox size increased [Checked in: Comment 11]

http://hg.mozilla.org/comm-central/rev/aef8948fd115

Requesting approval this low risk fix to comm-aurora

Comment 12

[Philip Chee]

Pushed to comm-beta
http://hg.mozilla.org/releases/comm-beta/rev/73cf5f055600
Already in comm-aurora.