550601 - D2D rendering breaks -moz-linear-gradient in crashed-plugin UI

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Justin Dolske [:Dolske]]

The crashed-plugin UI should have a background with gray stripes. See http://blog.mozilla.com/dolske/2010/02/10/crashed-plugin-ui/ for examples.

I noticed with my current trunk nightly (Win7 x64), that the stripes are no longer being displayed. Instead I just get a solid gray background.

To trigger this UI, visit http://flashcrash .dempsky .org/ which will trigger a Flash crash. (Or kill mozilla-runtime.exe, etc.)

Comment 1

[Bas Schouten (:bas.schouten)]

How is this drawn? I don't seem to be getting any call into cairo with a CAIRO_PATTERN_TYPE_LINEAR.

Comment 2

[Asbjørn Riis-Knudsen]

I can confirm that the gradient is missing when D2D is enabled. Strange...

Comment 3

[Michael Ventnor]

Gradients are drawn under nsCSSRendering::PaintGradient(). The plugin crash UI uses a repeating gradient which is a special case:

  // Set repeat mode. Default cairo extend mode is PAD.
  if (aGradient->mRepeating) {
    gradientPattern->SetExtend(gfxPattern::EXTEND_REPEAT);
  }

Comment 4

[u88484]

Attachment: testcase

For some reason the flash content is needed for the lines to show up correctly.

Comment 5

[u88484]

(In reply to comment #4)
> Created an attachment (id=430954) [details]
> testcase
> 
> For some reason the flash content is needed for the lines to show up correctly.
...with d2d disabled that is.

The gradient does not show up with d2d enabled.

Comment 6

[Justin Dolske [:Dolske]]

FWIW, I just noticed that the gradient *is* being drawn, just that it's not being tiled over the entire content area. In the upper left of the plugin UI, there's one dark stripe faintly visible (hard to see because the color is so similar).

Comment 7

[Jeff Muizelaar [:jrmuizel]]

This should be fixed now.