550704 - js/src/config/check-sync-dirs.py doesn't check file contents

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

From the python documentation:
filecmp.cmp(f1, f2[, shallow])
    Compare the files named f1 and f2, returning True if they seem equal, False otherwise.
    Unless shallow is given and is false, files with identical os.stat() signatures are taken to be equal.

In check-sync-dirs.py, shallow is not given, and if the compared files happen to have the same modification time and size, but not the same content, an error won't be emitted.

You'd think it's not important and highly improbable, but it just happened to me: I had significantly different config/rules.mk files, with same size and modification time (due to the fact the source was unpacked, then patched, so all the patches filed were modified within the same second), and the differences weren't (obviously) spotted.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch [Checkin: Comment 3 & 5 & 6]

Comment 2

[(not currently active) Ted Mielczarek]

cjones hit this the other day in the opposite case, he had two config.mk files with the same contents, but different mtimes or something like that, and the script was complaining. That default behavior of filecmp is bizarre to me.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 430862 [details] [diff] [review]
Patch
[Checkin: Comment 3 & 5 & 6]


http://hg.mozilla.org/mozilla-central/rev/d9808811bb01

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 430862 [details] [diff] [review]
Patch
[Checkin: Comment 3 & 5 & 6]

Approved for 1.9.2.3 and 1.9.1.10, a=dveditz for release-drivers

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 430862 [details] [diff] [review]
Patch
[Checkin: Comment 3 & 5 & 6]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/52991d0b8a5b

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 430862 [details] [diff] [review]
Patch
[Checkin: Comment 3 & 5 & 6]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3a731a04de7c