550710 - emptytext attribute broken

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dave Garrett]

The emptytext attribute doesn't work in latest Trunk. Error console gives:

Error: uncaught exception: [Exception... "Not enough arguments"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: chrome://global/content/bindings/textbox.xml ::  :: line 160"  data: no]

Just taking a quick look at the patch in bug 547224 I see: 	

159  if (this.hasAttribute("emptytext"))
160    this.placeholder = this.setAttribute("emptytext");

Should be getAttribute not setAttribute.

Comment 1

[Dão Gottwald [:dao]]

Thanks!

I just fixed this typo:

http://hg.mozilla.org/mozilla-central/rev/41dcb515943d

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Did we not have any tests break for this? Seems like we should...

Comment 3

[Dão Gottwald [:dao]]

All the tests have been migrated to "placeholder" in bug 547224...

Comment 4

[:Gavin Sharp [email: [e-mail]]]

We should either leave one using emptytext="", or make copies of some of the tests to test the other attribute.