550799 - Template root for fixed-sized arrays

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

+++ This bug was initially created as a clone of Bug #548702 +++

Not to grow the patch out of control the refactoring in the bug 548702 keeps the following code pattern:

jsval roots[2];
memset(roots, 0, sizeof roots);
JSAutoArrayRooter tvr(cx, roots, JS_ARRAY_LENGTH(roots));
...
root[0] = foo;
root[1] = bar;

We should replace it with template class like:

template<size_t N> 
class JSAutoRoots { 
   jsval data[N];   
  public:
   JSAutoRoots(JSContext *cx) ... { memset(data, 0, sizeof data); }
  
   jsval& operator[](size_t i) { JS_ASSERT(i < N); return data[i]; } 
...
};

With this class the above becomes:

JSAutoRoots roots(cx);
...
root[0] = foo;
root[1] = bar;

Comment 1

[Igor Bukanov]

This is no longer relevant in view of the conservative stack scanner.