550834 - change CRMFCertRequest structures to require an arenapool

Status: NEW

(NSS :: Libraries, defect, P5)

Description

[timeless]

Bug 340218 comment 5, Nelson Bolyard @ 2006-08-15 14:38:37 PDT

The current situation with CRMFCertRequest structures is a total mess.
Sometimes they're "stand alone" with their own arena.  
Sometimes they're part of the arena of another object.
Sometimes they may not have any arena at all.
Code cannot programmatically tell, by examination of the contents,
which of those cases applies to any one CRMFCertRequest structure.

I really want to see this all cleaned up.  

Here is a straw-man proposal:
- Change the code so that an arena is ALWAYS required.  
  CRMFCertRequest structures CANNOT exist without an arenapool.
- Ensure there is an arenapool pointer in the structure
- Add a flag to the structure that tells whether this pool belongs 
  exclusively to this structure, or belongs to another (parent) object.
- Have the CRMFCertRequest destroy function destroy the pool unless it
  belongs to another object.  

The issue I see with that proposal is that it changes public structures.
AFAIK, PSM is the only code in the world that uses it.  (This code is not
even in any of our shared libs, is it?)  So I don't think backwards binary
compatibility is really an issue.