550842 - need to ensure proper alignement of memory arena for RuleProcessorData::operator new

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Martin Husemann]

Attachment: Ensure pointer alignement for RuleProcessorData::operator new

RuleProcessorData contains a pointer, so on alignment critical architectures needs to be properly aligned.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So this is the problem bug 518003 comment 5 talks about, right?

Martin, is that patch not ready for review?  Or did you just forget to request review?

Comment 2

[Martin Husemann]

yes, I wasn't aware of that comment in #518003 (and didn't know whom to ask for review, but apparently I could request w/o requestee)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 431063 [details] [diff] [review]
Ensure pointer alignement for RuleProcessorData::operator new

Asking no one in particular doesn't actually let anyone know about the review request, though I think there are people who query for these.

But in any case, I'm the right reviewer for this.  ;)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed that patch as http://hg.mozilla.org/mozilla-central/rev/0905374b063d and then pushed http://hg.mozilla.org/mozilla-central/rev/1008f5c2e057 to fix the resulting compile errors.

Is this needed on branches?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: 1.9.2 branch merge

Requesting branch approval.  Risk is very low, and this should fix crashes on some architectures.

Comment 6

[LegNeato]

Comment on attachment 431431 [details] [diff] [review]
1.9.2 branch merge

a=LegNeato for 1.9.2.5. Please ONLY land this on mozilla-1.9.2 default, as we are still working on 1.9.2.4 on the relbranch

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Landed the above "1.9.1 branch merge" patch on 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a23cd8be70f0