Closed
Bug 550842
Opened 14 years ago
Closed 14 years ago
need to ensure proper alignement of memory arena for RuleProcessorData::operator new
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .5-fixed |
People
(Reporter: martin, Assigned: martin)
Details
Attachments
(2 files)
801 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
1.58 KB,
patch
|
christian
:
approval1.9.2.5+
|
Details | Diff | Splinter Review |
RuleProcessorData contains a pointer, so on alignment critical architectures needs to be properly aligned.
Comment 1•14 years ago
|
||
So this is the problem bug 518003 comment 5 talks about, right? Martin, is that patch not ready for review? Or did you just forget to request review?
Assignee | ||
Updated•14 years ago
|
Attachment #431063 -
Flags: review?
Assignee | ||
Comment 2•14 years ago
|
||
yes, I wasn't aware of that comment in #518003 (and didn't know whom to ask for review, but apparently I could request w/o requestee)
Comment 3•14 years ago
|
||
Comment on attachment 431063 [details] [diff] [review] Ensure pointer alignement for RuleProcessorData::operator new Asking no one in particular doesn't actually let anyone know about the review request, though I think there are people who query for these. But in any case, I'm the right reviewer for this. ;)
Attachment #431063 -
Flags: review? → review+
Updated•14 years ago
|
Assignee: nobody → martin
Comment 4•14 years ago
|
||
Pushed that patch as http://hg.mozilla.org/mozilla-central/rev/0905374b063d and then pushed http://hg.mozilla.org/mozilla-central/rev/1008f5c2e057 to fix the resulting compile errors. Is this needed on branches?
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
Requesting branch approval. Risk is very low, and this should fix crashes on some architectures.
Attachment #431431 -
Flags: approval1.9.2.3?
Comment on attachment 431431 [details] [diff] [review] 1.9.2 branch merge a=LegNeato for 1.9.2.5. Please ONLY land this on mozilla-1.9.2 default, as we are still working on 1.9.2.4 on the relbranch
Attachment #431431 -
Flags: approval1.9.2.4? → approval1.9.2.5+
Landed the above "1.9.1 branch merge" patch on 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a23cd8be70f0
status1.9.2:
--- → .5-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•