Add Fennec strings for (CSP) Implement frame ancestor check

VERIFIED FIXED

Status

Fennec Graveyard
General
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Sudarsana Nagineni, Assigned: Sudarsana Nagineni)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
The commit for bug 515458 broke Fennec because it added strings to appstrings/neterror and Fennec has a forked copy.

It's possible that this also broke Camino.
(Assignee)

Comment 1

8 years ago
Created attachment 431093 [details] [diff] [review]
copy firefox string changes from mozilla-central 0b3cd1b80f3c

hg diff -U1 -c 0b3cd1b80f3c browser/locales/en-US/chrome/overrides/appstrings.properties browser/locales/en-US/chrome/overrides/netError.dtd) |patch -p2
Attachment #431093 - Flags: review?(mark.finkle)
(In reply to comment #0)
> It's possible that this also broke Camino.

As long as bug 515458 is only going to be landed on the trunk, it doesn't break us until our trunk builds succeed, but thanks for the heads up!
Attachment #431093 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/ddf98c3daa80
Assignee: nobody → naginenis
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Is there a test page for CSP that I can verify this against?
http://people.mozilla.org/~bsterne/content-security-policy/tests/frame-ancestors-test.cgi
Hm, the test case only passes for my trunk builds on winmo and maemo, but not on either of my 1.9.2 builds. If this landed on mobile-browser, it should be working on builds for both branches right?
(In reply to comment #6)
> Hm, the test case only passes for my trunk builds on winmo and maemo, but not
> on either of my 1.9.2 builds. If this landed on mobile-browser, it should be
> working on builds for both branches right?

No. The backend code is only on m-c
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a3pre) Gecko/20100311 Namoroka/3.7a3pre Fennec/1.1a2pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a3pre) Gecko/20100311 Namoroka/3.7a3pre Fennec/1.1a1
Status: RESOLVED → VERIFIED
Whiteboard: [Need Ver Fennec1.9.2]
Whiteboard: [Need Ver Fennec1.9.2]
You need to log in before you can comment on or make changes to this bug.