550869 - RSA_PrivateKeyCheck doesn't MP_DIGITS = 0 all locals before using CHECK_MPI_OK mp_init

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[timeless]

806  	RSA_PrivateKeyCheck(RSAPrivateKey *key)
808  	    mp_int p, q, n, psub1, qsub1, e, d, d_p, d_q, qInv, res;
811  	    MP_DIGITS(&n)    = 0;
812  	    MP_DIGITS(&psub1)= 0;
813  	    MP_DIGITS(&qsub1)= 0;
814  	    MP_DIGITS(&e)    = 0;
815  	    MP_DIGITS(&d)    = 0;
816  	    MP_DIGITS(&d_p)  = 0;
817  	    MP_DIGITS(&d_q)  = 0;
818  	    MP_DIGITS(&qInv) = 0;
819  	    MP_DIGITS(&res)  = 0;

821  	    CHECK_MPI_OK( mp_init(&p)    );

904  	cleanup:

907  	    mp_clear(&q);

when p init fails, it jumps to cleanup which tries to clear q which wasn't intialized

Comment 1

[timeless]

Attachment: patch

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Code is inside the FIPS boundary

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 431217 [details] [diff] [review]
patch

r=nelson

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Checking in rsa.c; new revision: 1.39.8.2; previous revision: 1.39.8.1

Thanks, Josh.