The default bug view has changed. See this FAQ.

Workers: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: timeless, Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

({coverity})

Trunk
x86
Linux
coverity
Points:
---

Firefox Tracking Flags

(status1.9.2 .4-fixed, status1.9.1 .10-fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
234 nsDOMWorkerTimeout::Init(JSContext* aCx, PRUint32 aArgc, jsval* aArgv,

248   PRUint32 interval;
249   if (aArgc > 1) {
250     if (!JS_ValueToECMAUint32(aCx, aArgv[1], (uint32*)&interval)) {
255   }
256   else {

if aArgc <= 1, interval is uninitialized

260   }
261 
262   mInterval = interval;
Created attachment 431170 [details] [diff] [review]
Patch
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #431170 - Flags: superreview?(jst)
Attachment #431170 - Flags: review?(jst)
Summary: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1 → Workers: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1

Updated

7 years ago
Attachment #431170 - Flags: superreview?(jst)
Attachment #431170 - Flags: superreview+
Attachment #431170 - Flags: review?(jst)
Attachment #431170 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/06b335512dc6
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Attachment #431170 - Flags: approval1.9.2.3?
Attachment #431170 - Flags: approval1.9.1.10?
Comment on attachment 431170 [details] [diff] [review]
Patch

Approved for 1.9.2.3 and 1.9.1.10, a=dveditz for release-drivers
Attachment #431170 - Flags: approval1.9.2.3?
Attachment #431170 - Flags: approval1.9.2.3+
Attachment #431170 - Flags: approval1.9.1.10?
Attachment #431170 - Flags: approval1.9.1.10+
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/53b97163051a
status1.9.2: --- → .3-fixed
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/01e46340ef6d
status1.9.1: --- → .10-fixed
status1.9.2: .4-fixed → .3-fixed
Unless you landed this on the relbranch it's ".4-fixed"
status1.9.2: .3-fixed → .4-fixed
You need to log in before you can comment on or make changes to this bug.