550925 - Workers: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[timeless]

234 nsDOMWorkerTimeout::Init(JSContext* aCx, PRUint32 aArgc, jsval* aArgv,

248   PRUint32 interval;
249   if (aArgc > 1) {
250     if (!JS_ValueToECMAUint32(aCx, aArgv[1], (uint32*)&interval)) {
255   }
256   else {

if aArgc <= 1, interval is uninitialized

260   }
261 
262   mInterval = interval;

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/06b335512dc6

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 431170 [details] [diff] [review]
Patch

Approved for 1.9.2.3 and 1.9.1.10, a=dveditz for release-drivers

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/53b97163051a

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/01e46340ef6d

Comment 6

[Daniel Veditz [:dveditz]]

Unless you landed this on the relbranch it's ".4-fixed"