Closed Bug 550925 Opened 10 years ago Closed 10 years ago

Workers: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1

Categories

(Core :: DOM: Core & HTML, defect, minor)

x86
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- .4-fixed
status1.9.1 --- .10-fixed

People

(Reporter: timeless, Assigned: bent.mozilla)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

234 nsDOMWorkerTimeout::Init(JSContext* aCx, PRUint32 aArgc, jsval* aArgv,

248   PRUint32 interval;
249   if (aArgc > 1) {
250     if (!JS_ValueToECMAUint32(aCx, aArgv[1], (uint32*)&interval)) {
255   }
256   else {

if aArgc <= 1, interval is uninitialized

260   }
261 
262   mInterval = interval;
Attached patch PatchSplinter Review
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #431170 - Flags: superreview?(jst)
Attachment #431170 - Flags: review?(jst)
Summary: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1 → Workers: nsDOMWorkerTimeout::Init sets mInterval to an uninitialized value if aArgc <= 1
Attachment #431170 - Flags: superreview?(jst)
Attachment #431170 - Flags: superreview+
Attachment #431170 - Flags: review?(jst)
Attachment #431170 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/06b335512dc6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #431170 - Flags: approval1.9.2.3?
Attachment #431170 - Flags: approval1.9.1.10?
Comment on attachment 431170 [details] [diff] [review]
Patch

Approved for 1.9.2.3 and 1.9.1.10, a=dveditz for release-drivers
Attachment #431170 - Flags: approval1.9.2.3?
Attachment #431170 - Flags: approval1.9.2.3+
Attachment #431170 - Flags: approval1.9.1.10?
Attachment #431170 - Flags: approval1.9.1.10+
Unless you landed this on the relbranch it's ".4-fixed"
You need to log in before you can comment on or make changes to this bug.