Created attachment 431271 [details] [diff] [review] Make check-interactive run valgrind Right now only hacks work, like jduell's attached patch.
Hm, for our other test suite targets in testsuite-targets.mk, we support an EXTRA_TEST_ARGS var, but we never ported that to check-one / check-interactive. Alternately, we could support a variable so you could do like "make check-one SOLO_FILE=test_foo.js VALGRIND=1" and have that append the correct --debugger flags like jduell's patch does.
This is the incantation I use to run a single test under valgrind with e10s: SOLO_FILE=test_channel_close_wrap.js make EXTRA_TEST_ARGS="--debugger valgrind --debugger-args '--smc-check=all --trace-children=yes'" -C fennec-dbg/netwerk/test/ check-one It's the kind of thing I either turn into a script and forget about or lobby to improve.
Summary: Add target to run tests under valgrind → Add target to run xpcshell tests under valgrind
Whiteboard: [good first bug]
:jdm, would you be willing to [mentor=jdm] this bug?
I think the presence of mach (and the --debugger flag) makes this unnecessary.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.