Closed
Bug 551095
Opened 15 years ago
Closed 12 years ago
Add target to run xpcshell tests under valgrind
Categories
(Testing :: XPCShell Harness, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jdm, Unassigned)
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
|
1.34 KB,
patch
|
Details | Diff | Splinter Review |
Right now only hacks work, like jduell's attached patch.
|
||
Updated•15 years ago
|
Attachment #431271 -
Attachment is patch: true
Attachment #431271 -
Attachment mime type: application/octet-stream → text/plain
|
|
||
Comment 1•15 years ago
|
||
Hm, for our other test suite targets in testsuite-targets.mk, we support an EXTRA_TEST_ARGS var, but we never ported that to check-one / check-interactive. Alternately, we could support a variable so you could do like
"make check-one SOLO_FILE=test_foo.js VALGRIND=1"
and have that append the correct --debugger flags like jduell's patch does.
|
Reporter | |
Comment 2•15 years ago
|
||
This is the incantation I use to run a single test under valgrind with e10s:
SOLO_FILE=test_channel_close_wrap.js make EXTRA_TEST_ARGS="--debugger valgrind --debugger-args '--smc-check=all --trace-children=yes'" -C fennec-dbg/netwerk/test/ check-one
It's the kind of thing I either turn into a script and forget about or lobby to improve.
|
|
Reporter | |
Updated•14 years ago
|
Summary: Add target to run tests under valgrind → Add target to run xpcshell tests under valgrind
Whiteboard: [good first bug]
|
|
Reporter | |
Comment 4•12 years ago
|
||
I think the presence of mach (and the --debugger flag) makes this unnecessary.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(josh)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•