Closed
Bug 551112
Opened 15 years ago
Closed 15 years ago
Script resolution policy should match that of Domain's
Categories
(Tamarin Graveyard :: Virtual Machine, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
flash10.1
People
(Reporter: rreitmai, Assigned: rreitmai)
References
Details
Attachments
(1 file)
|
5.39 KB,
patch
|
edwsmith
:
review+
kpalacz
:
review+
|
Details | Diff | Splinter Review |
This is a mirror of the issue addressed in Bug 543898 (re: the same issue exists with scripts as it does with Traits).
|
Assignee | |
Updated•15 years ago
|
|
|
Assignee | |
Updated•15 years ago
|
Summary: Traits resolution dependent on abc parsing order, not Domain hierarchy → Script resolution policy should match that of Domain's
|
|
Assignee | |
Comment 1•15 years ago
|
||
First rev of patch, which resolves this bug and bug 551116 (PoolObject policy), and 551004 (recursion).
I can rip apart into separate patches if needed.
At this point looking for feedback , acceptance is running cleanly, will attempt to run an ATS sandbox later this eve.
Attachment #431496 -
Flags: review?(edwsmith)
Assignee: nobody → rreitmai
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
|
||
Updated•15 years ago
|
Attachment #431496 -
Flags: review?(edwsmith) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 431496 [details] [diff] [review]
scripts to mirror the traits lookup rules
Looks ok to me.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #431496 -
Flags: review?(kpalacz)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Comment on attachment 431496 [details] [diff] [review]
scripts to mirror the traits lookup rules
Adding Jeff for review.
Code is passing all ATS testing along with player sandboxes which includes AIR.
Attachment #431496 -
Flags: review?(jodyer)
|
||
Comment 4•15 years ago
|
||
Is the "only export one name for an accessor" still needed?
|
|
Assignee | |
Comment 5•15 years ago
|
||
Good catch, I've removed it since addNamedScript() calls getNamedScript() first before adding.
|
|
Assignee | |
Comment 6•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Attachment #431496 -
Flags: review?(kpalacz) → review+
|
||
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Comment 7•15 years ago
|
||
Comment on attachment 431496 [details] [diff] [review]
scripts to mirror the traits lookup rules
removing jodyer from feedback list.
Attachment #431496 -
Flags: review?(jodyer)
You need to log in
before you can comment on or make changes to this bug.
Description
•