Closed
Bug 551129
Opened 15 years ago
Closed 15 years ago
Restore tests from TestPermanentAtoms.cpp
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a3
People
(Reporter: sicking, Assigned: sicking)
References
Details
(Keywords: assertion)
Attachments
(1 file)
|
7.47 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
In bug 534136 I removed TestPermanentAtoms.cpp from the build (but not from the tree) since it was using outdated API and I was rewriting atom tests anyway.
However upon further inspection the things that were tested there didn't actually get tested in the new tests. Specifically NS_NewPermanentAtom doesn't have any tests.
Patch attached that
* Adds the same tests for NS_NewPermanentAtom that TestPermanentAtoms.cpp had.
* Kills off TestPermanentAtoms.cpp from the tree.
* Disables asserting tests in debug builds. See bug 549098 for why.
Attachment #431312 -
Flags: review?(jst)
|
||
Updated•15 years ago
|
Attachment #431312 -
Flags: review?(jst) → review+
|
Assignee | |
Comment 1•15 years ago
|
||
Checked in, thanks for the quick review
http://hg.mozilla.org/mozilla-central/rev/120330e515e6
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Assignee: nobody → jonas
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.3a3
|
|
||
Updated•15 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•