Restore tests from TestPermanentAtoms.cpp

RESOLVED FIXED in mozilla1.9.3a3

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

({assertion})

Trunk
mozilla1.9.3a3
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch Patch to fixSplinter Review
In bug 534136 I removed TestPermanentAtoms.cpp from the build (but not from the tree) since it was using outdated API and I was rewriting atom tests anyway.

However upon further inspection the things that were tested there didn't actually get tested in the new tests. Specifically NS_NewPermanentAtom doesn't have any tests.

Patch attached that

* Adds the same tests for NS_NewPermanentAtom that TestPermanentAtoms.cpp had.
* Kills off TestPermanentAtoms.cpp from the tree.
* Disables asserting tests in debug builds. See bug 549098 for why.
Attachment #431312 - Flags: review?(jst)
Attachment #431312 - Flags: review?(jst) → review+
Checked in, thanks for the quick review

http://hg.mozilla.org/mozilla-central/rev/120330e515e6
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → jonas
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.3a3
Blocks: 551153, 534136
Depends on: 549100
Keywords: assertion
Depends on: 552798
You need to log in before you can comment on or make changes to this bug.