551233 - Workers: Possible to release nsGlobalWindow on a background thread

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

I'm utterly surprised, but the nsISupportsHashKey implementation actually addrefs/releases its key value when used. Simple fix.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 431415 [details] [diff] [review]
Patch

We're code frozen on 1.9.1.9 and 1.9.2.2, so moving these to the next version.

This will need to land and bake on trunk, first.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/e68368ef5c04

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d5bfbe40cf5f

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/698585763a49

Comment 5

[Reed Loden [:reed]]

Please don't remove the "needed" part from the blocking1.9.2/1.9.1 flags. That means something to drivers and should be left alone.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm guessing that was an accident ... /me shakesfist at bugzilla!

Comment 7

[Al Billings [:abillings - ex-MoCo]]

Is there anything for QA to verify with this bug? I suspect not.

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #7)
> Is there anything for QA to verify with this bug? I suspect not.

Yeah, not really. I just magically hit it one day... It requires precise timing.