http://hg.mozilla.org/mozilla-central/file/5f4acba26bdc/toolkit/mozapps/update/content/updates.js#l565 That function has this code: var pm = document.getElementById("checkingProgress"); checkingProgress.setAttribute("mode", "normal"); checkingProgress is not defined in this function and pm is not used. Is this code called at all?
Thanks for catching that!
Assignee: nobody → robert.bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Damn... that code has been that way since 6/6/2005! http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/update/content/updates.js&rev=1.83&mark=570#570
Created attachment 431574 [details] [diff] [review] simple patch
It might not matter much, but I'd prefer pm.mode = ... and pm.value = ... Setting the value property will send an accessibility event, setting the attribute won't. Were you able to trigger a "checkingProgress is undefined" kind of error?
Will do... I wasn't able to trigger it likely due to it completing the download before the event and I don't have the time to investigate this thoroughly atm with the Lorentz and Quarter 1 goals work.
Created attachment 431601 [details] [diff] [review] simple patch rev2
Created attachment 431602 [details] [diff] [review] simple patch rev2
Attachment #431602 - Flags: review?(dolske)
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/6960c848f6e1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Created attachment 449083 [details] [diff] [review] 1.9.2 patch Simple patch that I'd like to get this for Firefox 3.6.5.
Comment on attachment 449083 [details] [diff] [review] 1.9.2 patch We will not be taking this for 3.6.6. Moving approval request forward. If you disagree, send me an email.
Comment on attachment 449083 [details] [diff] [review] 1.9.2 patch Resetting request so I get the approval email if this gets approved
Depends on: 576939
Comment on attachment 449083 [details] [diff] [review] 1.9.2 patch I'm going to add this to a rollup patch in Bug 576939 for 1.9.2
Attachment #449083 - Flags: approval184.108.40.206?
Fixed on 1.9.2 for Firefox 3.6.9 by bug 576939.
status1.9.1: --- → wontfix
status1.9.2: --- → .9-fixed
You need to log in before you can comment on or make changes to this bug.