Status

Release Engineering
General
P5
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: jhford, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

instead of blocking bug 538517 because unit tests are not working, I am filing this bug.  

This bug is to:
-fix MobileParseTestLog in buildbotcustom/steps/mobile.py
-verify that unit test configs are re-enabled in production and staging.
Assignee: nobody → jhford
Depends on: 538517
Priority: -- → P5
Created attachment 433634 [details] [diff] [review]
custom fixes needed

this patch fixes some issues with the unittest factory.  It still isn't working 100%, but this patch gets us to the point where we aren't able to run the unittests because maemkit isn't launching them properly.
Attachment #433634 - Flags: review?(aki)
(Assignee)

Comment 2

8 years ago
Comment on attachment 433634 [details] [diff] [review]
custom fixes needed

>-        ))
>-        self.addSteps(simpleHG(self.hg_host, self.maemkit_repo_path, self.base_dir, 'maemkit'))
>+            ))
>+        self.addSteps(simpleHG(self.hg_host,
>+                               self.maemkit_repo_path, self.base_dir, 'maemkit'))

Nit that you've pointed out in person.
r=me with that fixed.
Attachment #433634 - Flags: review?(aki) → review+
Created attachment 433652 [details] [diff] [review]
unittest fixes for n900

indentation fixed
Attachment #433634 - Attachment is obsolete: true
Attachment #433652 - Flags: review?(aki)
(Assignee)

Updated

8 years ago
Attachment #433652 - Flags: review?(aki) → review+
marking as dependent on bug 525327 so we can reliably get the test archive name.
Depends on: 525327
http://hg.mozilla.org/build/buildbotcustom/rev/49adecbe65bd

this fixes an issue where there are no multi locale tests on tinderbox builds.
(Assignee)

Comment 6

8 years ago
Created attachment 434061 [details] [diff] [review]
cfgs missing timeout-log

Traceback (most recent call last):
  File "maemkit-chunked.py", line 22, in <module>
    main()
  File "maemkit-chunked.py", line 19, in main
    runTest(mk)
  File "maemkit-chunked.py", line 13, in runTest
    testdriver.prepTests()
  File "/builds/maemkit/mochidriver.py", line 217, in prepTests
    self.ignoreTimeouts()
  File "/builds/maemkit/mochidriver.py", line 178, in ignoreTimeouts
    if (os.path.exists(self.options["timeout-log"])):
KeyError: 'timeout-log'

I think this patch should fix this problem.
Attachment #434061 - Flags: review?(jmaher)
Comment on attachment 434061 [details] [diff] [review]
cfgs missing timeout-log

yeah, I sort of screwed a few things up with my early winmo work in maemkit.  I need to revisit maemkit as a lot of the functionality in there is in the main harnesses already.
Attachment #434061 - Flags: review?(jmaher) → review+
(Assignee)

Comment 8

8 years ago
Comment on attachment 434061 [details] [diff] [review]
cfgs missing timeout-log

http://hg.mozilla.org/qa/maemkit/rev/ae79639f32bf
Attachment #434061 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Assignee: jhford → aki
No longer depends on: 525327
(Assignee)

Comment 9

8 years ago
xpcshell appears to be broken on the n810s as well.
(Assignee)

Comment 10

8 years ago
Created attachment 435820 [details] [diff] [review]
update configs for unit tests, limited staging

Looks like this is working.
Attachment #435820 - Flags: review?(jhford)
(Assignee)

Comment 11

8 years ago
Created attachment 435821 [details] [diff] [review]
replace MobileParseTestLog with version in mobiletestfactory.py
Attachment #435821 - Flags: review?(jhford)
(Assignee)

Comment 12

8 years ago
Created attachment 435843 [details] [diff] [review]
now with 100% more production
Attachment #435820 - Attachment is obsolete: true
Attachment #435843 - Flags: review?(jhford)
Attachment #435820 - Flags: review?(jhford)
Comment on attachment 435821 [details] [diff] [review]
replace MobileParseTestLog with version in mobiletestfactory.py

looks great :)
Attachment #435821 - Flags: review?(jhford) → review+
Comment on attachment 435843 [details] [diff] [review]
now with 100% more production

looks good :)
(Assignee)

Comment 15

8 years ago
Comment on attachment 435843 [details] [diff] [review]
now with 100% more production

(actually marking r+ w/ verbal confirmation)

http://hg.mozilla.org/build/buildbot-configs/rev/68e8c2aa9168
Attachment #435843 - Flags: review?(jhford) → review+
(Assignee)

Comment 16

8 years ago
Comment on attachment 435821 [details] [diff] [review]
replace MobileParseTestLog with version in mobiletestfactory.py

http://hg.mozilla.org/build/buildbotcustom/rev/89c66c6acb07
Attachment #435821 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Attachment #435843 - Flags: checked-in+
(Assignee)

Comment 17

8 years ago
Since xpcshell is just as busted as the n810s, we're done here.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 18

8 years ago
Hmmmmm.
The new unit tests didn't get picked up til there was a restart, not a reconfig; we probably need to reload the config and defaults vars in master.cfg.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.