Closed
Bug 551310
Opened 15 years ago
Closed 15 years ago
fix unit tests on n900s
Categories
(Release Engineering :: General, defect, P5)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhford, Assigned: mozilla)
References
Details
Attachments
(4 files, 2 obsolete files)
2.79 KB,
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
1.24 KB,
patch
|
jmaher
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
6.03 KB,
patch
|
jhford
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
14.14 KB,
patch
|
mozilla
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
instead of blocking bug 538517 because unit tests are not working, I am filing this bug.
This bug is to:
-fix MobileParseTestLog in buildbotcustom/steps/mobile.py
-verify that unit test configs are re-enabled in production and staging.
Reporter | ||
Updated•15 years ago
|
Reporter | ||
Comment 1•15 years ago
|
||
this patch fixes some issues with the unittest factory. It still isn't working 100%, but this patch gets us to the point where we aren't able to run the unittests because maemkit isn't launching them properly.
Attachment #433634 -
Flags: review?(aki)
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 433634 [details] [diff] [review]
custom fixes needed
>- ))
>- self.addSteps(simpleHG(self.hg_host, self.maemkit_repo_path, self.base_dir, 'maemkit'))
>+ ))
>+ self.addSteps(simpleHG(self.hg_host,
>+ self.maemkit_repo_path, self.base_dir, 'maemkit'))
Nit that you've pointed out in person.
r=me with that fixed.
Attachment #433634 -
Flags: review?(aki) → review+
Reporter | ||
Comment 3•15 years ago
|
||
indentation fixed
Attachment #433634 -
Attachment is obsolete: true
Attachment #433652 -
Flags: review?(aki)
Assignee | ||
Updated•15 years ago
|
Attachment #433652 -
Flags: review?(aki) → review+
Reporter | ||
Comment 4•15 years ago
|
||
marking as dependent on bug 525327 so we can reliably get the test archive name.
Depends on: 525327
Reporter | ||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/build/buildbotcustom/rev/49adecbe65bd
this fixes an issue where there are no multi locale tests on tinderbox builds.
Assignee | ||
Comment 6•15 years ago
|
||
Traceback (most recent call last):
File "maemkit-chunked.py", line 22, in <module>
main()
File "maemkit-chunked.py", line 19, in main
runTest(mk)
File "maemkit-chunked.py", line 13, in runTest
testdriver.prepTests()
File "/builds/maemkit/mochidriver.py", line 217, in prepTests
self.ignoreTimeouts()
File "/builds/maemkit/mochidriver.py", line 178, in ignoreTimeouts
if (os.path.exists(self.options["timeout-log"])):
KeyError: 'timeout-log'
I think this patch should fix this problem.
Attachment #434061 -
Flags: review?(jmaher)
Comment 7•15 years ago
|
||
Comment on attachment 434061 [details] [diff] [review]
cfgs missing timeout-log
yeah, I sort of screwed a few things up with my early winmo work in maemkit. I need to revisit maemkit as a lot of the functionality in there is in the main harnesses already.
Attachment #434061 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 8•15 years ago
|
||
Comment on attachment 434061 [details] [diff] [review]
cfgs missing timeout-log
http://hg.mozilla.org/qa/maemkit/rev/ae79639f32bf
Attachment #434061 -
Flags: checked-in+
Assignee | ||
Comment 9•15 years ago
|
||
xpcshell appears to be broken on the n810s as well.
Assignee | ||
Comment 10•15 years ago
|
||
Looks like this is working.
Attachment #435820 -
Flags: review?(jhford)
Assignee | ||
Comment 11•15 years ago
|
||
Attachment #435821 -
Flags: review?(jhford)
Assignee | ||
Comment 12•15 years ago
|
||
Attachment #435820 -
Attachment is obsolete: true
Attachment #435843 -
Flags: review?(jhford)
Attachment #435820 -
Flags: review?(jhford)
Reporter | ||
Comment 13•15 years ago
|
||
Comment on attachment 435821 [details] [diff] [review]
replace MobileParseTestLog with version in mobiletestfactory.py
looks great :)
Attachment #435821 -
Flags: review?(jhford) → review+
Reporter | ||
Comment 14•15 years ago
|
||
Comment on attachment 435843 [details] [diff] [review]
now with 100% more production
looks good :)
Assignee | ||
Comment 15•15 years ago
|
||
Comment on attachment 435843 [details] [diff] [review]
now with 100% more production
(actually marking r+ w/ verbal confirmation)
http://hg.mozilla.org/build/buildbot-configs/rev/68e8c2aa9168
Attachment #435843 -
Flags: review?(jhford) → review+
Assignee | ||
Comment 16•15 years ago
|
||
Comment on attachment 435821 [details] [diff] [review]
replace MobileParseTestLog with version in mobiletestfactory.py
http://hg.mozilla.org/build/buildbotcustom/rev/89c66c6acb07
Attachment #435821 -
Flags: checked-in+
Assignee | ||
Updated•15 years ago
|
Attachment #435843 -
Flags: checked-in+
Assignee | ||
Comment 17•15 years ago
|
||
Since xpcshell is just as busted as the n810s, we're done here.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 18•15 years ago
|
||
Hmmmmm.
The new unit tests didn't get picked up til there was a restart, not a reconfig; we probably need to reload the config and defaults vars in master.cfg.
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•