551310 - fix unit tests on n900s

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

instead of blocking bug 538517 because unit tests are not working, I am filing this bug.  

This bug is to:
-fix MobileParseTestLog in buildbotcustom/steps/mobile.py
-verify that unit test configs are re-enabled in production and staging.

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: custom fixes needed

this patch fixes some issues with the unittest factory.  It still isn't working 100%, but this patch gets us to the point where we aren't able to run the unittests because maemkit isn't launching them properly.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 433634 [details] [diff] [review]
custom fixes needed

>-        ))
>-        self.addSteps(simpleHG(self.hg_host, self.maemkit_repo_path, self.base_dir, 'maemkit'))
>+            ))
>+        self.addSteps(simpleHG(self.hg_host,
>+                               self.maemkit_repo_path, self.base_dir, 'maemkit'))

Nit that you've pointed out in person.
r=me with that fixed.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: unittest fixes for n900

indentation fixed

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

marking as dependent on bug 525327 so we can reliably get the test archive name.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

http://hg.mozilla.org/build/buildbotcustom/rev/49adecbe65bd

this fixes an issue where there are no multi locale tests on tinderbox builds.

Comment 6

[Aki Sasaki (not active)]

Attachment: cfgs missing timeout-log

Traceback (most recent call last):
  File "maemkit-chunked.py", line 22, in <module>
    main()
  File "maemkit-chunked.py", line 19, in main
    runTest(mk)
  File "maemkit-chunked.py", line 13, in runTest
    testdriver.prepTests()
  File "/builds/maemkit/mochidriver.py", line 217, in prepTests
    self.ignoreTimeouts()
  File "/builds/maemkit/mochidriver.py", line 178, in ignoreTimeouts
    if (os.path.exists(self.options["timeout-log"])):
KeyError: 'timeout-log'

I think this patch should fix this problem.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 434061 [details] [diff] [review]
cfgs missing timeout-log

yeah, I sort of screwed a few things up with my early winmo work in maemkit.  I need to revisit maemkit as a lot of the functionality in there is in the main harnesses already.

Comment 8

[Aki Sasaki (not active)]

Comment on attachment 434061 [details] [diff] [review]
cfgs missing timeout-log

http://hg.mozilla.org/qa/maemkit/rev/ae79639f32bf

Comment 9

[Aki Sasaki (not active)]

xpcshell appears to be broken on the n810s as well.

Comment 10

[Aki Sasaki (not active)]

Attachment: update configs for unit tests, limited staging

Looks like this is working.

Comment 11

[Aki Sasaki (not active)]

Attachment: replace MobileParseTestLog with version in mobiletestfactory.py

Comment 12

[Aki Sasaki (not active)]

Attachment: now with 100% more production

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 435821 [details] [diff] [review]
replace MobileParseTestLog with version in mobiletestfactory.py

looks great :)

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 435843 [details] [diff] [review]
now with 100% more production

looks good :)

Comment 15

[Aki Sasaki (not active)]

Comment on attachment 435843 [details] [diff] [review]
now with 100% more production

(actually marking r+ w/ verbal confirmation)

http://hg.mozilla.org/build/buildbot-configs/rev/68e8c2aa9168

Comment 16

[Aki Sasaki (not active)]

Comment on attachment 435821 [details] [diff] [review]
replace MobileParseTestLog with version in mobiletestfactory.py

http://hg.mozilla.org/build/buildbotcustom/rev/89c66c6acb07

Comment 17

[Aki Sasaki (not active)]

Since xpcshell is just as busted as the n810s, we're done here.

Comment 18

[Aki Sasaki (not active)]

Hmmmmm.
The new unit tests didn't get picked up til there was a restart, not a reconfig; we probably need to reload the config and defaults vars in master.cfg.