551312 - get mobile-master ready for QT and allow browser_wait to be specified in config.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

we are currently using a hardcode of 7 as the browser wait, this is going to make things ugly when we put the N810s on the new master.

This bug is to track the addition of the platform browser_wait option in to defaults.py, read it in master.cfg and set it up properly in mobiletestfactoryrw.py

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbotcustom patch

still need to test the buildbot-configs patch that makes this useful

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 436721 [details] [diff] [review]
buildbotcustom patch

Something tells me you just switched editors again, and it wasn't a good choice.  Please attach a good patch.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

no, that was done with vim and hg (admittedly on windows).  I have no clue what went wrong with the patch as I can read it in windows.  New patch coming up.

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbotcustom patch v2

I have opened this and the last patch many times without issue using Vim.  I have no clue what is going on here, but I am going to stop using windows for any development after this.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbot-configs patch v1

this patch combines the staging and production defaults.py and master.cfg files.  In order to distinguish whether a master is using the production or staging configs we should create a symlink from the appropriate file to config.py

I don't know if there should be a seperate defaults.py file for each environment.  As staging should match production, I am inclined not to have this duplication.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Morphing this bug to also cover setting up QT test runs.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 436778 [details] [diff] [review]
buildbot-configs patch v1

this patch does:
-delete mobile-rw-staging
-merge master.cfg and put environment specific settings into config-*.py
-split config.py to be config-staging.py and config.py

Comment 8

[Aki Sasaki (not active)]

Comment on attachment 436778 [details] [diff] [review]
buildbot-configs patch v1

Just the staging-mobile-master in the email in the mailnotifier... should be a cinch to put in the MASTER dictionary.

Also -- one thing I noticed with the debsign/ dir is that this is a harder layout to checkconfig.  If you could whip up something like test-masters.sh to test configs without a bunch of manual softlinking, that would rock.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbot-configs patch v2

corrected email issue and added test-masters.sh

Comment 10

[Aki Sasaki (not active)]

Comment on attachment 436815 [details] [diff] [review]
buildbot-configs patch v2

remove the $CHKCONFSUFFIX references.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 436815 [details] [diff] [review]
buildbot-configs patch v2

http://hg.mozilla.org/build/buildbot-configs/rev/2b1939358bce

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 436764 [details] [diff] [review]
buildbotcustom patch v2

http://hg.mozilla.org/build/buildbotcustom/rev/bdebbdf1e60d