Closed Bug 551312 Opened 14 years ago Closed 14 years ago

get mobile-master ready for QT and allow browser_wait to be specified in config.py

Categories

(Release Engineering :: General, defect, P5)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhford, Assigned: jhford)

References

Details

Attachments

(2 files, 2 obsolete files)

we are currently using a hardcode of 7 as the browser wait, this is going to make things ugly when we put the N810s on the new master.

This bug is to track the addition of the platform browser_wait option in to defaults.py, read it in master.cfg and set it up properly in mobiletestfactoryrw.py
Priority: -- → P5
Attached patch buildbotcustom patch (obsolete) — Splinter Review
still need to test the buildbot-configs patch that makes this useful
Attachment #436721 - Flags: review?(aki)
Comment on attachment 436721 [details] [diff] [review]
buildbotcustom patch

Something tells me you just switched editors again, and it wasn't a good choice.  Please attach a good patch.
Attachment #436721 - Flags: review?(aki) → review-
no, that was done with vim and hg (admittedly on windows).  I have no clue what went wrong with the patch as I can read it in windows.  New patch coming up.
I have opened this and the last patch many times without issue using Vim.  I have no clue what is going on here, but I am going to stop using windows for any development after this.
Attachment #436721 - Attachment is obsolete: true
Attachment #436764 - Flags: review?(aki)
Attachment #436764 - Flags: review?(aki) → review+
Attached patch buildbot-configs patch v1 (obsolete) — Splinter Review
this patch combines the staging and production defaults.py and master.cfg files.  In order to distinguish whether a master is using the production or staging configs we should create a symlink from the appropriate file to config.py

I don't know if there should be a seperate defaults.py file for each environment.  As staging should match production, I am inclined not to have this duplication.
Morphing this bug to also cover setting up QT test runs.
Summary: allow browser_wait to be specified in config.py → get mobile-master ready for QT and allow browser_wait to be specified in config.py
Comment on attachment 436778 [details] [diff] [review]
buildbot-configs patch v1

this patch does:
-delete mobile-rw-staging
-merge master.cfg and put environment specific settings into config-*.py
-split config.py to be config-staging.py and config.py
Attachment #436778 - Flags: review?(aki)
Comment on attachment 436778 [details] [diff] [review]
buildbot-configs patch v1

Just the staging-mobile-master in the email in the mailnotifier... should be a cinch to put in the MASTER dictionary.

Also -- one thing I noticed with the debsign/ dir is that this is a harder layout to checkconfig.  If you could whip up something like test-masters.sh to test configs without a bunch of manual softlinking, that would rock.
Attachment #436778 - Flags: review?(aki) → review-
corrected email issue and added test-masters.sh
Attachment #436778 - Attachment is obsolete: true
Attachment #436815 - Flags: review?(aki)
Comment on attachment 436815 [details] [diff] [review]
buildbot-configs patch v2

remove the $CHKCONFSUFFIX references.
Attachment #436815 - Flags: review?(aki) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: