Placeholder (emptytext) styling on Modern broken by bug 547224

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Themes
--
minor
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: ewong)

Tracking

({modern, regression})

Trunk
seamonkey2.1b1
modern, regression
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Modern's placeholder should have a colour of #999999 but since bug 547224 it has a colour of GrayText.
(Assignee)

Updated

7 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
Created attachment 479796 [details] [diff] [review]
Fixed Placeholder styling on Modern.
Attachment #479796 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
Attachment #479796 - Flags: review?(neil) → review?(neil)
(Reporter)

Comment 2

7 years ago
Comment on attachment 479796 [details] [diff] [review]
Fixed Placeholder styling on Modern.

>+html|*.textbox-textarea:-moz-placeholder  {
Nit: only needs the one space before the {

>-
Nit: don't delete this line.

r=me with those fixed.
Attachment #479796 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 480005 [details] [diff] [review]
Fixed Placeholder styling on Modern. r=Neil

Fixed nits.
Attachment #479796 - Attachment is obsolete: true
Attachment #480005 - Flags: review+

Comment 4

7 years ago
Comment on attachment 480005 [details] [diff] [review]
Fixed Placeholder styling on Modern. r=Neil

Did you want this checked in?
Attachment #480005 - Attachment description: Fixed Placeholder styling on Modern. → Fixed Placeholder styling on Modern. r=Neil
(Assignee)

Comment 5

7 years ago
(In reply to comment #4)
> Comment on attachment 480005 [details] [diff] [review]
> Fixed Placeholder styling on Modern. r=Neil
> 
> Did you want this checked in?

I wasn't sure if a sr? was needed. If it doesn't, I'll set the
checkin-needed.
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Comment 6

7 years ago
http://hg.mozilla.org/comm-central/rev/6d5edabbcbe8
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.