Closed
Bug 551545
Opened 15 years ago
Closed 14 years ago
Placeholder (emptytext) styling on Modern broken by bug 547224
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b1
People
(Reporter: neil, Assigned: ewong)
References
Details
(Keywords: modern, regression)
Attachments
(1 file, 1 obsolete file)
558 bytes,
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
Modern's placeholder should have a colour of #999999 but since bug 547224 it has a colour of GrayText.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #479796 -
Flags: review?(neil)
Assignee | ||
Updated•14 years ago
|
Attachment #479796 -
Flags: review?(neil) → review?(neil)
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 479796 [details] [diff] [review]
Fixed Placeholder styling on Modern.
>+html|*.textbox-textarea:-moz-placeholder {
Nit: only needs the one space before the {
>-
Nit: don't delete this line.
r=me with those fixed.
Attachment #479796 -
Flags: review?(neil) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Fixed nits.
Attachment #479796 -
Attachment is obsolete: true
Attachment #480005 -
Flags: review+
Comment 4•14 years ago
|
||
Comment on attachment 480005 [details] [diff] [review]
Fixed Placeholder styling on Modern. r=Neil
Did you want this checked in?
Attachment #480005 -
Attachment description: Fixed Placeholder styling on Modern. → Fixed Placeholder styling on Modern. r=Neil
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #4)
> Comment on attachment 480005 [details] [diff] [review]
> Fixed Placeholder styling on Modern. r=Neil
>
> Did you want this checked in?
I wasn't sure if a sr? was needed. If it doesn't, I'll set the
checkin-needed.
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•