55176 - urlbar history drop-down doesn't update

Status: VERIFIED DUPLICATE of bug 53922

(SeaMonkey :: UI Design, defect, P3)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Use Mozilla build
2. Clear profile
3. Manually 20 different urls into the urlbar
4. Click on the arrow in the right of the urlbar

Actual result:
Only the first (10) urls show up in the urlbar history drop-down, and they sit
there until you clear the profile again. I.e. in step 4., you see the *first* 10
urls.

Expected result:
The urls fill up the urlbar history drop-down until an upper bound (e.g. 10),
and then are replaced by the most recent ones. I.e. in step 4., you see the
*last* 10 urls.

Environment:
Linux, both my own, optimized build and a nightly. IIRC, I've never seen this
working correctly.

Additional comments:
Somebody else on IRC (don't remember who) also saw this bug.
Of course, this makes the urlbar history unusable.

Comment 1

[Ben Bucksch (:BenB)]

ping?

Comment 2

[Blake Ross]

Radha, how does all this work?  Where is the max amount of items allowable in 
the URL bar popup specified?  Why am I able to add more than 10 items to the 
list if I remove:

       while (entries.hasMoreElements()) {
	     var entry = entries.getNext();
		 if (entry) {
		   entry = entry.QueryInterface
(Components.interfaces.nsIRDFLiteral);
           var url = entry.Value;
		   if (url == urlToAdd) {
		 //     dump("URL already in urlbar history\n");
			  return;
		   }  
         }  //entry

And why can I still not add two of the same URL to the list even after I remove 
the above code?  Is there other code for this that I'm missing?

Comment 3

[Radha on family leave (not reading bugmail)]

I have a patch ready to checkin that will list the latest 
entries. (see bug # 53922)The number of items shown in the list is controlled by 
MAX_HISTORY_MENU_ITEMS  defined in sessionHistoryUI.js. You can add as many 
items you want to the urlbar history. But only MAX_HISTORY_MENU_ITEMS will be 
shown.

Comment 4

[Blake Ross]

Man, I'm dumb. Right above what I was looking at (addToUrlbarHistory()) was the 
function I was looking for (createUBHistoryMenu()).

Anyways, so is this a dup of 53922?

Comment 5

[Radha on family leave (not reading bugmail)]

Change the summary so that it reflects just the following problem

No, let this bug be open for the problem where when you type in a url that is 
already in the history, the drop down menu doesn't update to show the latest 
entered url. reassigning to self.

Comment 6

[Ben Bucksch (:BenB)]

Th bug as originally reported is a DUP of bug 53922, yes.

However, radha, if you want, feel free to morph this bug.

Comment 7

[Claudius Gayle]

Radha sez:
"when you type in a url that is  already in the history, the drop down menu doesn't update
to show the latest entered url"

I thought this was already dealt with in the in the bug 53922 patch, JFD's words:

Now, urlbar history always show the most 15 recent URL, the last one at the top.
If you re-enter a existing url, it move to the top of the list.

Am i reading wrong? IF there is still a problem, change the summary of this bug. If not,
then we should mark it as a dupe of bug 53922

Comment 8

[Radha on family leave (not reading bugmail)]

claudius, you are right. Once 53922 is fixed. this wil be fixed too.

Comment 9

[Claudius Gayle]

*** This bug has been marked as a duplicate of 53922 ***

Comment 10

[Claudius Gayle]

VERIFIED Dupe