551762 - tsspider measures pageload, not just the test executions

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It should just measure the test execution.

Comment 1

[Chris AtLee [:catlee]]

Have a patch?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: [checked in]Proposed patch

Comment 3

[alice nodelman [:alice] [:anode]]

Should only get checked in during a downtime.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Is there a procedure for scheduling those?  Or should I just talk to a sheriff on some day of my choosing?

Comment 5

[alice nodelman [:alice] [:anode]]

I've set this as a blocking bug for the next releng downtime.  We'll get it landed for you.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Alice, thanks!

Comment 7

[alice nodelman [:alice] [:anode]]

Would it be okay to replace this sunspider with the sunspider being run as part of the dromaeo testing?

Comment 8

[Robert Sayre]

(In reply to comment #7)
> Would it be okay to replace this sunspider with the sunspider being run as part
> of the dromaeo testing?

no, this is closer to the actual harness used in sunspider. dromaeo's harness is a confounder.

Comment 9

[Boris Zbarsky [:bzbarsky]]

In particular, due to the way dromaeo runs the tests it actually ends up measuring quite different things from the original sunspider.

Comment 10

[Boris Zbarsky [:bzbarsky]]

So did this end up landing?  I seem to recall that it did....

Comment 11

[alice nodelman [:alice] [:anode]]

This was checked in and talos code is checked-out per run, so you're good to go.