Closed
Bug 551879
Opened 16 years ago
Closed 16 years ago
TM: remove shell/js.cpp and editline.c warnings
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.29 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
GCC says:
editline.c
../../editline/editline.c: In function ‘TTYflush’:
../../editline/editline.c:172: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
js.cpp
../../shell/js.cpp: In function ‘void CancelExecution(JSRuntime*)’:
../../shell/js.cpp:3537: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result
Attached patch fixes. It's clumsy, but I don't see how to do it better. No idea who to ask for review, so asking Igor because I've never asked him before!
Attachment #432062 -
Flags: review?(igor)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 432062 [details] [diff] [review]
patch
Stealing. Just some lame inconsequential shell code.
Attachment #432062 -
Flags: review?(igor) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•