Closed Bug 551879 Opened 13 years ago Closed 13 years ago

TM: remove shell/js.cpp and editline.c warnings

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
1.29 KB, patch
gal
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
GCC says:

editline.c
../../editline/editline.c: In function ‘TTYflush’:
../../editline/editline.c:172: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
js.cpp
../../shell/js.cpp: In function ‘void CancelExecution(JSRuntime*)’:
../../shell/js.cpp:3537: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result


Attached patch fixes.  It's clumsy, but I don't see how to do it better.  No idea who to ask for review, so asking Igor because I've never asked him before!
Attachment #432062 - Flags: review?(igor)
Comment on attachment 432062 [details] [diff] [review]
patch

Stealing. Just some lame inconsequential shell code.
Attachment #432062 - Flags: review?(igor) → review+
http://hg.mozilla.org/tracemonkey/rev/26bc20777fd8
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/26bc20777fd8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.