Closed Bug 551941 Opened 11 years ago Closed 11 years ago

fix unify to recognize 64-bit Mach-O files

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

64-bit Mach-O files use a different magic number in the header vs. 32-bit Mach-O files, per:
http://developer.apple.com/Mac/library/documentation/DeveloperTools/Conceptual/MachORuntime/Reference/reference.html#//apple_ref/c/tag/mach_header

'unify' currently only looks for 32-bit Mach-O files, so it will fail to unify a 32-bit file with a 64=bit file. This patch simply makes it accept the 64-bit Mach-O magic number as well, so unifying an i386 and x86_64 binary works.
Attachment #432123 - Flags: review?(benjamin)
Attachment #432123 - Flags: review?(benjamin) → review+
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/9a69e95ba6fc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.