552105 - PR_OpenSemaphore does not set the error code properly on Windows CE

Status: RESOLVED WONTFIX

(NSPR :: NSPR, defect)

Description

[Alex Pakhotin (:alexp)]

PR_OpenSemaphore called for a non-existing semaphore is expected to set the error code to PR_FILE_NOT_FOUND_ERROR, but instead it sets it to PR_UNKNOWN_ERROR on Windows CE.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

Set the last error in our own implementation of the OpenSemaphore function for WinCE to the same value as in the native NT version of the function.

Comment 2

[Wan-Teh Chang]

Comment on attachment 432249 [details] [diff] [review]
Fix

r=wtc.

What's the original error code set by CreateSemaphoreW
in this case?

>+            /* The semaphore did not exist, so we set the last error like OpenSemaphore on NT */

Nit: wrap this long line (it seems longer than 80 characters).
Is there a better name for regular Windows than "NT"?

>+        }
>         else

Nit: This should be formatted as
          } else

Comment 3

[Alex Pakhotin (:alexp)]

(In reply to comment #2)
> What's the original error code set by CreateSemaphoreW
> in this case?

In this case CreateSemaphoreW just successfully creates a new semaphore, so the last error code is zero. We expect OpenSemaphore to fail though, so we just close the newly opened semaphore and set the error code to what is expected by other functions.

> >+            /* The semaphore did not exist, so we set the last error like OpenSemaphore on NT */
> 
> Nit: wrap this long line (it seems longer than 80 characters).
> Is there a better name for regular Windows than "NT"?

There is a difference between Windows NT and 95 in this case. The function _PR_MD_OPEN_SEMAPHORE below has a comment about this. So the name "NT" is consistent and makes sense here. I will put "Windows NT" there though to add a bit more context.

Comment 4

[Alex Pakhotin (:alexp)]

Attachment: Fix v2

Minor changes as per the code review.