552222 - Drop MOZ_XPFE_COMPONENTS / --disable-xpfe-components

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

MOZ_XPFE_COMPONENTS seems to have stemmed from the time of the original mobile build (maemo?) and from an embedder's build perspective.

Now that the embedding profiles have been dropped, and much of the non-browser items removed from xpfe/components, and all apps build xpfe/components by default AFAICT. Therefore I believe it is time we dropped the option to not build xpfe/components.

This has the normal wins of build simplification and option reduction.

Patch attached to drop the MOZ_XPFE_COMPONENTS switch. Note that with this the xpfe/Makefile.in becomes redundant and so the build switches into xpfe/components.

Comment 1

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/1e0e12538211

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Copy it to comm-central, (m-1.9.2+) [Checkin: Comment 5]

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 434540 [details] [diff] [review]
(Bv1-CC) Copy it to comm-central, (m-1.9.2+)
[Checkin: Comment 5]

I'm not sure, but I Think this shouldn't need to pass by Mark, he is review-buried. I'll look in more detail later though.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 434540 [details] [diff] [review]
(Bv1-CC) Copy it to comm-central, (m-1.9.2+)
[Checkin: Comment 5]

If you'd given me a few hours more, I'd have done the patch...

Anyway, we don't need this on trunk or 1.9.2.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 434540 [details] [diff] [review]
(Bv1-CC) Copy it to comm-central, (m-1.9.2+)
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/7f7cfb9b939b