552227 - Mochitest for bug 513439 is built regardless of whether tests are enabled

Status: NEW

(Core :: Graphics, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The patch for bug 513439 unconditionally added "mochitest" to the DIRS variable in gfx/thebes/Makefile.in, rather than adding it inside a ifdef ENABLE_TESTS block (or including it as part of the test/ Makefile). 

The patch also seems to have added mochitest/ as a child of thebes/ instead as of a child of (the existing, and already-properly-ifdefed-in-thebes/Makefile.in) thebes/test/ directory, like other modules do (see, e.g., libpr0n/Makefile.in and libpr0n/test/Makefile.in).

Comment 1

[Sylvain Pasche]

The first issue was fixed by bug 515993 on mozilla-central apparently.

For the second one, I think I didn't put it in gfx/thebes/test because that directory was only traversed if MOZ_ENABLE_LIBXUL and BUILD_STATIC_LIBS were not defined. But I guess we could move that condition inside the Makefile in the test directory and move mochitests there (i.e. do something like http://mxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/tests/Makefile.in).