552236 - History not saved to disk on quit

Status: RESOLVED FIXED

(Camino Graveyard :: History, defect)

Description

[Christopher Henderson]

Places doesn't save history to disk on quitting Camino. We need to package nsPlacesDBFlush.js and send Places the 'quit-application' message when shutting down embedding.

Comment 1

[Christopher Henderson]

Attachment: Fix v1.0

Adds nsPlacesDBFlush.js to the project, and notifies observers (particularly nsPlacesDBFlush) of the 'quit-application' signal when shutting down.

Please note that this is a hg diff file.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 432660 [details] [diff] [review]
Fix v1.0

f+

Thanks for being attentive to the alphabet, too :-)

Comment 3

[Stuart Morgan]

Comment on attachment 432660 [details] [diff] [review]
Fix v1.0

>+  if (observerService) {
>     observerService->NotifyObservers(nsnull, "profile-change-net-teardown", nsnull);
>-  
>+    observerService->NotifyObservers(nsnull, "quit-application", nsnull);
>+  }
>+
>   // phase 2 notifcation (we really are about to terminate)
>   [[NSNotificationCenter defaultCenter] postNotificationName:XPCOMShutDownNotificationName object:nil];

Does the ordering of quit-application and our XPCOMShutDownNotification matter? I'm wondering if we might cause things to be closed down while our objects still want to use them.

Comment 4

[Christopher Henderson]

Attachment: Fix v1.2

The order doesn't matter too much at the moment, but looking at other Camino code it would make more sense to notify Gecko observers after Camino observers.

Comment 5

[Stuart Morgan]

Comment on attachment 434680 [details] [diff] [review]
Fix v1.2

sr=smorgan

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/1c12818b9959

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/4c64f9b49b84