Closed
Bug 552241
Opened 15 years ago
Closed 15 years ago
nsIContentViewer::PermitUnload API has changed
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chris, Assigned: chris)
Details
(Whiteboard: [cm192test])
Attachments
(1 file, 1 obsolete file)
|
927 bytes,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
nsIContentViewer::PermitUnload now takes 2 parameters: a PR_Bool that "indicates that the current caller will close the window", plus the out parameter.
|
Assignee | |
Comment 1•15 years ago
|
||
Update code to use new function signature.
Assignee: nobody → trendyhendy2000
Status: NEW → ASSIGNED
Attachment #432375 -
Flags: superreview?(stuart.morgan+bugzilla)
|
||
Comment 2•15 years ago
|
||
Why PR_FALSE then? The only case we call PermitUnload ourselves is when closing a window/tab, which sounds like what this boolean is for.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Yeah, looking at it again, that makes sense.
Attachment #432375 -
Attachment is obsolete: true
Attachment #432457 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #432375 -
Flags: superreview?(stuart.morgan+bugzilla)
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 432457 [details] [diff] [review]
Fix v.1.1
sr=smorgan
Attachment #432457 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Whiteboard: [cm192test]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•