nsIContentViewer::PermitUnload API has changed

RESOLVED FIXED

Status

Camino Graveyard
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Christopher Henderson, Assigned: Christopher Henderson)

Tracking

1.9.2 Branch
All
Mac OS X

Details

(Whiteboard: [cm192test])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
nsIContentViewer::PermitUnload now takes 2 parameters: a PR_Bool that "indicates that the current caller will close the window", plus the out parameter.
(Assignee)

Comment 1

8 years ago
Created attachment 432375 [details] [diff] [review]
Fix

Update code to use new function signature.
Assignee: nobody → trendyhendy2000
Status: NEW → ASSIGNED
Attachment #432375 - Flags: superreview?(stuart.morgan+bugzilla)

Comment 2

8 years ago
Why PR_FALSE then? The only case we call PermitUnload ourselves is when closing a window/tab, which sounds like what this boolean is for.
(Assignee)

Comment 3

8 years ago
Created attachment 432457 [details] [diff] [review]
Fix v.1.1

Yeah, looking at it again, that makes sense.
Attachment #432375 - Attachment is obsolete: true
Attachment #432457 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #432375 - Flags: superreview?(stuart.morgan+bugzilla)

Comment 4

8 years ago
Comment on attachment 432457 [details] [diff] [review]
Fix v.1.1

sr=smorgan
Attachment #432457 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/c964bca19ff1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.