552251 - text-decoration should not underline images (imgs)

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[kwutzke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)

Take any HTML with links, this examplary:

<a href="http://www.postgresql.org/docs/current/static/datatype-numeric.html">numeric types</a>

Associate the following CSS (the rule means "put a small 'link external' PNG after the link if it starts with 'http'"):

a[href^="http"]:after
{
    content: url(/images/link-external.png);
}

Now also define a general hover (or other) underline rule:

a:hover
{
    color: red;
    text-decoration: underline;
}

All external links will be rendered with the image being underlined, too, as well as the whitespace between the image and the text. This looks really ugly. Instead, only the text should be underlined. It should look like in IE 8...

Reproducible: Always

Steps to Reproduce:
1. see details
2.
3.
Actual Results:  
Underlined image + whitespace

Expected Results:  
Non-underlined image + whitespace

Not underline image + whitespace :-)

Comment 1

[kwutzke]

Attachment: Firefox rendering

Comment 2

[kwutzke]

Attachment: IE rendering

Comment 3

[q0k]

I've written some testing at http://pastebin.mozilla.org/708107, did not get the image underlined. Can you submit an HTML attachment please?

Comment 4

[kwutzke]

Tried some hours, it seems to be doctype related. Any doctype I tried XHTML 1.1, XHTML 1.0 strict and trans, HTML 4.01 strict and trans cause the behavior. Omitting the doctype renders those links correctly.

I put the correction up into pastebin for you to see the underlined image. Hope this gets fixed soon.

Comment 5

[kwutzke]

Attachment: HTML showing the described behavior

Comment 6

[zug_treno]

Related to/duplicate of Core bug 280296?

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Slightly, but really it's a duplicate of the bug (or one of the sub-bugs :-) on rewriting text-decoration to follow the new CSS 2.1 rules, since those rules say images don't get underlined.

Comment 8

[Vitor Menezes]

The patch for bug 403524 makes it so that text-decorations are drawn only on text in all modes.

Comment 9

[kwutzke]

Which version of Firefox 3 will be the first one to show this fix?

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Firefox 8, most likely.  (Firefox 3.6.* receives security updates only.)