Closed Bug 552297 Opened 15 years ago Closed 6 years ago

All profiler code should be inside #ifdef AVMPLUS_SAMPLER instead of #ifdef DEBUGGER

Categories

(Tamarin Graveyard :: Profiler, defect, P4)

Product:
Tamarin Graveyard
Component:
Profiler
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Q1 12 - Brannan

People

(Reporter: mike, Unassigned)

References

Details

Minor cleanup that would be nice to do in flash10.2: Currently most profiler code is inside #ifdef DEBUGGER, implying that the profiler build and the debugger build are synonymous. Since there is already a profiler-specific ifdef, AVMPLUS_SAMPLER, it would make more sense for profiler code to be inside #ifdef AVMPLUS_SAMPLER instead of #ifdef DEBUGGER. For example, this would apply to: - all code in SamplerScript.* - all the implementations of ScriptObject::bytesUsed and so on.
By the way, AVMPLUS_DEBUGGER is indirectly turned on by DEBUGGER. To be specific, in avmshell-features.h, AVMFEATURE_DEBUGGER turns on AVMFEATURE_ALLOCATION_SAMPLER, and in avmfeatures.h, AVMFEATURE_ALLOCATION_SAMPLER turns on AVMPLUS_SAMPLER. So the point of this bug is to just change the ifdefs in the source; it would have no impact on the capabilities of the different builds of Tamarin.
Assignee: nobody → mmoreart
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Priority: -- → P4
Target Milestone: --- → flash10.2
Blocks: Profiler_bugs
Assignee: mmoreart → nobody
Component: Virtual Machine → Profiler
QA Contact: vm → profiler
Target Milestone: Q3 11 - Serrano → Q1 12 - Brannan
No assignee, updating the status.
Status: ASSIGNED → NEW
No assignee, updating the status.
No assignee, updating the status.
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in before you can comment on or make changes to this bug.