552365 - Test plugin is not present on test machines

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

E.g.
http://tinderbox.mozilla.org/showlog.cgi?lohttp://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268620304.1268622921.937.gzg=Firefox/1268620304.1268622921.937.gz

REFTEST TEST-KNOWN-FAIL | file:///builds/moz2_slave/mozilla-central-linux-debug-unittest-reftest/build/reftest/tests/modules/plugin/test/reftest/plugin-sanity.html |

That's from the test
fails-if(!haveTestPlugin) == plugin-sanity.html div-sanity.html

!haveTestPlugin is true on all test machines currently, it seems. I don't know how long this had been going on.

I'm not sure if this is Build Config or Releng, or something else...

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Note, the test plugin seems to be there OK on the try servers, just not on trunk Tinderbox.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Given that things seem to be OK on the try-server, I'm guessing this must be Releng.

Comment 3

[Justin Dolske [:Dolske]]

The test plugin seems to be packaged for tests in testing/mochitest/Makefile.in; did something change so the split-out reftest runs no longer extract that? Or did they never extract it, and it just happens to work if the slave has previously run Mochitests and bits are leftover?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Better log url:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268620304.1268622921.937.gz

Note that the try server runs unit tests in the tree they're built in, while m-c runs them using packaged build/tests/symbols.

I see bin/plugins/libnptest.so being unpacked out of the tests archive, as well as several files in mochitest/browser/toolkit/mozapps/plugins/.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #3)
The different test jobs all run in their own directory, so there's no chance of that type of cross talk. They unpack the full tests archive regardless of the subset they may actually use.

Comment 6

[(not currently active) Ted Mielczarek]

I guess this has just never worked? That's kind of sad. Simple fix: add the --extra-profile-file to the runreftest.py call, like mochitest has:
http://hg.mozilla.org/build/buildbotcustom/file/tip/steps/unittest.py#l503

Comment 7

[(not currently active) Ted Mielczarek]

I guess I was too thorough in bug 473935, since that conveniently masked these failures by making them KNOWN-FAIL.

Comment 8

[(not currently active) Ted Mielczarek]

Attachment: simple fix

This should fix it, although I haven't tested the patch.

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 432532 [details] [diff] [review]
simple fix

changeset:   648:707481400567

Landing this today.

Comment 10

[[e-mail] (:bhearsum)]

seems to have landed ok.