Closed
Bug 552525
Opened 15 years ago
Closed 15 years ago
Get rid of container classes with static functions in CTypes.h/cpp
Categories
(Core :: js-ctypes, defect, P1)
Core
js-ctypes
Tracking
()
RESOLVED
FIXED
People
(Reporter: dwitte, Assigned: dwitte)
References
Details
Attachments
(1 file)
|
24.32 KB,
patch
|
mozilla+ben
:
review+
|
Details | Diff | Splinter Review |
Right now we have all the various CTypes functions declared in empty classes as static functions. We should use a namespace for them instead, and move static JSAPI callback declarations into CTypes.cpp directly.
|
Assignee | |
Comment 1•15 years ago
|
||
P1, need this for 1.9.3. (Trivial to fix, and silly code is silly.)
Priority: -- → P1
|
|
Assignee | |
Comment 2•15 years ago
|
||
Changes definitions from 'class Foo' to 'namespace Foo', and moves JSAPI functions into CTypes.cpp.
No substantive code changes.
|
||
Comment 3•15 years ago
|
||
Comment on attachment 435066 [details] [diff] [review]
patch v1
Looks good.
Attachment #435066 -
Flags: review?(bnewman) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Comment on attachment 435066 [details] [diff] [review]
patch v1
http://hg.mozilla.org/mozilla-central/rev/f95c9e28869c
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•