552548 - Use JSString accessors in ctypes instead of JS_GetStringChars

Status: RESOLVED FIXED

(Core :: js-ctypes, defect, P1)

Description

[[e-mail]]

JS_GetStringChars can allocate, to guarantee a null-terminated buffer. That's bad; we don't need it, and it can fail.

This requires moving ctypes into js/src.

Comment 1

[[e-mail]]

P1, need this for 1.9.3. (Trivial to fix and it's a correctness bug.)

Comment 2

[[e-mail]]

Attachment: like so

Comment 3

[Ben Newman (:bnewman) (:benjamn)]

Comment on attachment 438005 [details] [diff] [review]
like so

> static JS_ALWAYS_INLINE bool
> IsEllipsis(jsval v)
> {
>   if (!JSVAL_IS_STRING(v))
>     return false;
>   JSString* str = JSVAL_TO_STRING(v);
>-  if (JS_GetStringLength(str) != 3)
>-    return false;
>-  jschar* chars = JS_GetStringChars(str), dot('.');
>+  if (str->length() != 3)
>+    return false;
>+  const jschar* chars = str->chars(), dot('.');
>   return (chars[0] == dot &&
>           chars[1] == dot &&
>           chars[2] == dot);
> }

It's a shame how the `chars`s don't all line up vertically now.

Comment 4

[Ben Newman (:bnewman) (:benjamn)]

(In reply to comment #3)
> It's a shame how the `chars`s don't all line up vertically now.

Actually, it is kind of cool how the `char` part still aligns:

  const jschar
  return (char
          char
          char

r=me, after all

Comment 5

[[e-mail]]

Comment on attachment 438005 [details] [diff] [review]
like so

http://hg.mozilla.org/tracemonkey/rev/3db08f1327b2

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/3db08f1327b2