552679 - Add Mobile OSs to TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Android builds coming soon.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Since yesterday, we now have android nightly builds - can these be added to TBPL?

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #1)
> Since yesterday, we now have android nightly builds - can these be added to
> TBPL?

Of course, that should be build-on-checkin *and* nightly builds! You can see them here: http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mobile

Comment 3

[Aki Sasaki (not active)]

I don't think we have any mobile builds atm.
Not sure if that invalidates this, or expands the request to cover all of mobile.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Any ETA on getting these builds into TBPL?


(In reply to comment #3)
> I don't think we have any mobile builds atm.
> Not sure if that invalidates this, or expands the request to cover all of
> mobile.

Aki: sorry, dont follow. /me looks at http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mobile and sees lots of Android, maemo4, maemo5 builds.

Comment 5

[Markus Stange [:mstange]]

So on the Mobile tree we need these platforms, right?
Android, Linux, Maemo (includes N810), OSX, Win

That means we need to add a "runs on these platforms" field per tree, and do some reorganizing. I'll see what I can do.

Comment 6

[Aki Sasaki (not active)]

(In reply to comment #4)
> Any ETA on getting these builds into TBPL?
> 
> 
> (In reply to comment #3)
> > I don't think we have any mobile builds atm.
> > Not sure if that invalidates this, or expands the request to cover all of
> > mobile.
> 
> Aki: sorry, dont follow. /me looks at
> http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mobile and sees lots of
> Android, maemo4, maemo5 builds.

We have zero mobile builds in tbpl afaik.
Therefore, adding Android builds is either invalid or should be expanded to cover the full mobile tree.

Comment 7

[Arpad Borsos [:Swatinem]]

Attachment: patch

Now that we don't have a matrix anymore, it becomes very easy to add new OSs. I've also done a bit OS-handling refactoring, also modified the performance comparator to only show OSs for which there are results, otherwise it would overflow and create a scrollbar not that there are a lot more OSs.

Another question: Maemo without version number is Maemo 4, right?

Comment 8

[(no longer active)]

Wouldn't it be more elegant to just add a function which returns the object property names as an array, and remove the OSKeys array?

Comment 9

[Aki Sasaki (not active)]

(In reply to comment #7)
> Another question: Maemo without version number is Maemo 4, right?

That's correct.

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 450912 [details] [diff] [review]
patch

Yeah, what Ehsan said. There's a _keysFromObject function in UserInterface.js, move it anywhere you like.

Comment 11

[Arpad Borsos [:Swatinem]]

Attachment: fixed [pushed: comment 13]

(In reply to comment #10)
> (From update of attachment 450912 [details] [diff] [review])
> Yeah, what Ehsan said. There's a _keysFromObject function in UserInterface.js,
> move it anywhere you like.

Thanks, I moved it into Controller.

Comment 12

[Markus Stange [:mstange]]

Comment on attachment 453693 [details] [diff] [review]
fixed [pushed: comment 13]

>diff --git a/js/Controller.js b/js/Controller.js

>     UserInterface.init(this);
> 
>     this.forceRefresh();
>   },
> 
>+
>   getData: function Controller_getData() {

No need for this blank line. Looks great otherwise.

Comment 13

[Arpad Borsos [:Swatinem]]

Comment on attachment 453693 [details] [diff] [review]
fixed [pushed: comment 13]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/f75476fa2a7e
Thanks.

Comment 14

[Markus Stange [:mstange]]

deployed, thanks

Comment 15

[Mike Taylor [:bear]]

Thanks for adding Android!