Closed Bug 552688 Opened 11 years ago Closed 11 years ago

Clean up .autoreg leftovers

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a4

People

(Reporter: sgautherie, Assigned: philor)

References

()

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: in-testsuite-
Um, not exactly. XPCOM doesn't own Firefox's installer, though it does own some other mentions that should and can go away now, and it doesn't own SeaMonkey's installer, where it should and can go away now, nor does it have any reviewers in common with SeaMonkey's installer, and it doesn't own Thunderbird's installer, where it can't go away yet and which is the only thing that depends on bug 544237, and it also doesn't have any reviewers in common with that either. Feel free to file a bug for your product, in its own product, as I will for mine, but this single bug is not suitable for all three.
Assignee: nobody → philringnalda
Severity: trivial → normal
Status: NEW → ASSIGNED
No longer depends on: C192Branch
OS: Windows 2000 → All
Hardware: x86 → All
Summary: No need to keep removing .autoreg from Windows uninstaller: removed-files.in is enough → Clean up .autoreg leftovers
Attached patch FixSplinter Review
Not terribly exciting, but as a bonus along with making it more obvious that I'll never again need to puzzle out what .autoreg thinks it's doing (other than being something dead that should be removed), this way we'll be trying to remove it on update/install, where we're already eating the cost of trying to remove a ton of things that don't actually exist, instead of in startup.
Attachment #433513 - Flags: review?(benjamin)
Comment on attachment 433513 [details] [diff] [review]
Fix

The comment in nsEmbedFunctions is incorrect, CheckCompatibility is in nsAppRunner.cpp, not NS_InitXPCOM3. r=me with that change
Attachment #433513 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/e3c21e4b1d7d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
Comment on attachment 437165 [details] [diff] [review]
(Bv1-SM) Clean up installer.nsi
[Moved to bug 601978]

I have no say over installer, Frank owns that.
Attachment #437165 - Flags: review?(kairo) → review?(bugzilla)
Comment on attachment 437165 [details] [diff] [review]
(Bv1-SM) Clean up installer.nsi
[Moved to bug 601978]

Ping for a(ny) review...
Attachment #437165 - Flags: review?(bugspam.Callek)
Comment on attachment 437165 [details] [diff] [review]
(Bv1-SM) Clean up installer.nsi
[Moved to bug 601978]

I can review, but this is such an old bug, that we SURELY need our own. Please try  not to piggyback bugs like this, Bugs are cheap, please file one.
Attachment #437165 - Flags: review?(bugzilla)
Attachment #437165 - Flags: review?(bugspam.Callek)
Attachment #437165 - Flags: review-
Blocks: 601978
(In reply to comment #8)
> I can review, but this is such an old bug, that we SURELY need our own. Please
> try  not to piggyback bugs like this, Bugs are cheap, please file one.

It certainly wasn't that old when I first requested review.
Bug 601978.
I still disagree, as http://dev.seamonkey.at/?d=x&i=mozilla&m=c has a 314 changes backlog (again).
Attachment #437165 - Attachment description: (Bv1-SM) Clean up installer.nsi → (Bv1-SM) Clean up installer.nsi [Moved to bug 601978]
Attachment #437165 - Attachment is obsolete: true
Attachment #437165 - Flags: review-
You need to log in before you can comment on or make changes to this bug.