552688 - Clean up .autoreg leftovers

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Phil Ringnalda (:philor)]

Um, not exactly. XPCOM doesn't own Firefox's installer, though it does own some other mentions that should and can go away now, and it doesn't own SeaMonkey's installer, where it should and can go away now, nor does it have any reviewers in common with SeaMonkey's installer, and it doesn't own Thunderbird's installer, where it can't go away yet and which is the only thing that depends on bug 544237, and it also doesn't have any reviewers in common with that either. Feel free to file a bug for your product, in its own product, as I will for mine, but this single bug is not suitable for all three.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix

Not terribly exciting, but as a bonus along with making it more obvious that I'll never again need to puzzle out what .autoreg thinks it's doing (other than being something dead that should be removed), this way we'll be trying to remove it on update/install, where we're already eating the cost of trying to remove a ton of things that don't actually exist, instead of in startup.

Comment 3

[Benjamin Smedberg]

Comment on attachment 433513 [details] [diff] [review]
Fix

The comment in nsEmbedFunctions is incorrect, CheckCompatibility is in nsAppRunner.cpp, not NS_InitXPCOM3. r=me with that change

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/e3c21e4b1d7d

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-SM) Clean up installer.nsi [Moved to bug 601978]

Comment 6

[Robert Kaiser]

Comment on attachment 437165 [details] [diff] [review]
(Bv1-SM) Clean up installer.nsi
[Moved to bug 601978]

I have no say over installer, Frank owns that.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 437165 [details] [diff] [review]
(Bv1-SM) Clean up installer.nsi
[Moved to bug 601978]

Ping for a(ny) review...

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 437165 [details] [diff] [review]
(Bv1-SM) Clean up installer.nsi
[Moved to bug 601978]

I can review, but this is such an old bug, that we SURELY need our own. Please try  not to piggyback bugs like this, Bugs are cheap, please file one.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> I can review, but this is such an old bug, that we SURELY need our own. Please
> try  not to piggyback bugs like this, Bugs are cheap, please file one.

It certainly wasn't that old when I first requested review.
Bug 601978.
I still disagree, as http://dev.seamonkey.at/?d=x&i=mozilla&m=c has a 314 changes backlog (again).