552766 - Add NS_strdup to socorro skiplists

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Zack Weinberg (:zwol)]

Several different crashes have gotten aggregated under the signature 
[strlen | NS_strdup(char const*)] because NS_strdup is a generic utility function.  If you look at e.g. http://crash-stats.mozilla.com/report/index/b7e4a6aa-cade-4640-9cc2-59d4d2100316 you will see three associated bugs with totally different syndromes.

Please arrange for these crashes to be attributed to the caller of NS_strdup.  I don't care whether  "[strlen | NS_strdup(char const*) |" shows up as a prefix.

Comment 1

[Laura Thomson :laura]

If this is a priority for CrashKill, please update the whiteboard and summary.
https://wiki.mozilla.org/Breakpad/SkipList#CrashKill

Comment 2

[Zack Weinberg (:zwol)]

It is not a CrashKill priority.  I just happened to be looking at a crash report that would have been better categorized with this change.

Comment 3

[Laura Thomson :laura]

Working through old skiplist bugs.

We currently have
prefixSignatureRegEx = '|'.join([
...
  '.*strdup',
...
])

in the skiplist config (along with strlen), so you should no longer see this problem.  Please reopen if that's not the case.