552831 - patcher-config-bump.pl fails when flipping useBeta to True

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

It expects a beta-url to be present so that it can use BumpFilePath() on it and fails like this:
Use of uninitialized value in substitution (s///) at ../tools/release/patcher-config-bump.pl line 127.
Use of uninitialized value in pattern match (m//) at ../tools/release/patcher-config-bump.pl line 129.
Use of uninitialized value in pattern match (m//) at ../tools/release/patcher-config-bump.pl line 129.
Use of uninitialized value in concatenation (.) or string at ../tools/release/patcher-config-bump.pl line 140.
ASSERT: BumpFilePath() - Unknown file type for '' at ../tools/release/patcher-config-bump.pl line 140.

http://hg.mozilla.org/build/tools/file/69ed7e828538/release/patcher-config-bump.pl#l279
http://hg.mozilla.org/build/tools/file/69ed7e828538/release/patcher-config-bump.pl#l307

We could just bump the betatest-url path (and use it in the concatenation) if beta-url doesn't already exist.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Fallback to betatest-url

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Meant to say
* doesn't regress tests, such as they are (bug 521111 needs fixing)
* bumps moz192-branch-patcher.cfg sanely for 3.6.2

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Armen, post review steps are
* land in build/tools
* delete moz2-linux-slave12:/builds/slave/updates/*
* force new updates "build"
* force update verifies when updates finishes

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 432946 [details] [diff] [review]
Fallback to betatest-url

Thanks for fixing this, Nick.

Comment 5

[Armen [:armenzg]]

Comment on attachment 432946 [details] [diff] [review]
Fallback to betatest-url

http://hg.mozilla.org/build/tools/rev/858a55409566