552862 - allow Gecko to build and run on Mac OS X with MOZ_IPC defined

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

This patch gets Gecko building and running with MOZ_IPC defined. Plugins appear to load, subprocesses appear to start correctly, but instances cannot be created yet.

Note: We're targeting the following configuration for OOPP first: x86_64, Mac OS X 10.6, Cocoa event model, Core Graphics drawing model.

Comment 1

[Josh Aas]

Attachment: fix v1.0 [Checkin: See comment 4+5]

Comment 2

[Josh Aas]

We should probably only enable MOZ_IPC for 64-bit builds for now.

Comment 3

[Benjamin Smedberg]

Hrm, is 32-bit really any different from 64-bit in that configuration?

Comment 4

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b801e211d25f

Comment 5

[Serge Gautherie (:sgautherie)]

+
http://hg.mozilla.org/mozilla-central/rev/2b0b7d5000e5
Bustage fix, don't enable MOZ_IPC for PPC builds.
+
http://hg.mozilla.org/mozilla-central/rev/5e0706a64bba
Bustage fix, don't enable MOZ_IPC for i386 Mac OS X builds.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1-CC) Copy configure.in part to comm-central [Checkin: Comment 10]

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1-SM) Add pref("dom.ipc.plugins.enabled", ...) to SeaMonkey

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 434096 [details] [diff] [review]
(Ev1-SM) Add pref("dom.ipc.plugins.enabled", ...) to SeaMonkey

I'm not sure we can yet enable this, but even if we can; its not up to me to change this pref for us.

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 434089 [details] [diff] [review]
(Dv1-CC) Copy configure.in part to comm-central
[Checkin: Comment 10]

I notice this is correct per trunk current; but was not reflected in this bug here; if the additional changes are from other bugs can you please cite them in the checkin message (or at least the changesets you are porting from); thanks.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 434089 [details] [diff] [review]
(Dv1-CC) Copy configure.in part to comm-central
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/15ad2c7f4036

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)

I assume this comment is related to patch Ev1-SM rather than to Dv1-CC.
The latter just merges the 3 changesets from this bug.
The former already includes the wanted comment:
{
Port
*changeset ead78e10f225
*Bug 531142 - Tracking: turn on OOPP by default
too.
}

Comment 12

[Justin Wood (:Callek)]

(In reply to comment #11)
> (In reply to comment #9)
> 
> I assume this comment is related to patch Ev1-SM rather than to Dv1-CC.

No, Ev1-SM is simply the pref switch for SM and is not a bug port, the stuff in Dv1-CC is not solely the stuff cited in the message there, which is why I asked you to include the port info when you pushed it.

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to comment #12)
> the stuff in Dv1-CC is not solely the stuff cited in the message there

Which stuff exactly?

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 434096 [details] [diff] [review]
(Ev1-SM) Add pref("dom.ipc.plugins.enabled", ...) to SeaMonkey


Reviewer needed:
this is needed to fix failures on Md4 chunk!

Comment 15

[Robert Kaiser]

Comment on attachment 434096 [details] [diff] [review]
(Ev1-SM) Add pref("dom.ipc.plugins.enabled", ...) to SeaMonkey

AFAIK, we don't even build ipc.plugins (OOPP), so there's no real use in turning it on anywhere...

Comment 16

[Serge Gautherie (:sgautherie)]

Attachment: (Ev2-SM) Add pref("dom.ipc.plugins.enabled", ...) to SeaMonkey [Checkin: See comment 18]

Ev1-SM, with comment 15 suggestion(s).

Especially given bug 555234 (...), to test MOZ_IPC seems the best solution (ftb).

Comment 17

[Robert Kaiser]

Comment on attachment 436964 [details] [diff] [review]
(Ev2-SM) Add pref("dom.ipc.plugins.enabled", ...) to SeaMonkey
[Checkin: See comment 18]

confvars.sh undefines MOZ_IPC anyhow, so it always ends up false nowdays anyhow. Also, because of that, the comment is not needed and possibly even misleading here, just leave it out.

Comment 18

[Serge Gautherie (:sgautherie)]

Comment on attachment 436964 [details] [diff] [review]
(Ev2-SM) Add pref("dom.ipc.plugins.enabled", ...) to SeaMonkey
[Checkin: See comment 18]


http://hg.mozilla.org/comm-central/rev/6360778aa57d
Ev2-SM, with comment 17 suggestion(s).