552970 - download progress dialog doesn't remember position / coordinates

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Martin F.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.8) Gecko/20100205 Lightning/1.0b1 SeaMonkey/2.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.8) Gecko/20100205 Lightning/1.0b1 SeaMonkey/2.0.3

The download progress dialog doesn't seem to remember its position/coordinates, when being moved on the screen. On the next download it's centered again, which is pretting annoying when performing a dozen downloads a day.

This is a regression compared to SM1.x if I'n not mistaken.

Reproducible: Always

Steps to Reproduce:
1. Download a file from the web
2. Move the progress dialog to other coordinates.
3. Download another file
Actual Results:  
Next progess window appears centered again.

Expected Results:  
Progress dialog opens with coordinates of last used position.

Comment 1

[Justin Wood (:Callek)]

Attachment: v1.0 -- use persist

In my (very limited) testing of SM 1.1.7 with regard to this, it does not appear to be a regression.

However it does appear (easily) fixable.

This patch should do it.

Comment 2

[[e-mail]]

Comment on attachment 433108 [details] [diff] [review]
v1.0 -- use persist

I don't think we want to persist all of these.

Comment 3

[Martin F.]

May I ask what "sizemode" stands for?

Comment 4

[Robert Kaiser]

(In reply to comment #3)
> May I ask what "sizemode" stands for?

https://developer.mozilla.org/en/XUL:Attribute:sizemode

Comment 5

[Justin Wood (:Callek)]

(In reply to comment #2)
> (From update of attachment 433108 [details] [diff] [review])
> I don't think we want to persist all of these.

Order of priority for this bug, for the persists:

1) ScreenX, ScreenY <--- Per Summary
2) Width, Height    <--- I think also worth it
3) Sizemode         <--- I was less certain to even include it.

(In reply to comment #3)
> May I ask what "sizemode" stands for?

Sure, its basically, maximized vs positioned/windowed.

Comment 6

[Justin Wood (:Callek)]

Attachment: v2 -- just screenx and screeny

Comment 7

[Justin Wood (:Callek)]

Pushed as http://hg.mozilla.org/comm-central/efae333beb46

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 433217 [details] [diff] [review]
v2 -- just screenx and screeny

Low-Risk, actually would make this work better for some 2.0 users.

Comment 9

[Robert Kaiser]

Comment on attachment 433217 [details] [diff] [review]
v2 -- just screenx and screeny

It's a functionality change, and I'm a bit reluctant to allow those on a stable branch, but it's so simple, so let's just do it.

Comment 10

[Justin Wood (:Callek)]

Heh, slipped through my todo-cracks:
Pushed as: http://hg.mozilla.org/releases/comm-1.9.1/rev/9b39f09b7ccd