553137 - Update Gecko strings for 1.9.2

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We'd need to do this anyway, but filing as a placeholder now to clear it off my list of unfiled To-Dos and into a real bug tracking system.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

plugins.properties (the one from dom/global) has an added string for the version.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> plugins.properties (the one from dom/global) has an added string for the
> version.

While fixing this, we ought to fix the other strings there to match Camino style (title, header).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I have started on this, but going is slow (among other things, there are now twice as many properties files as on 1.9.0).

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Update on this: the slog is as slow as ever (especially with MXR sucking as it is wont to do anymore), but I've now gone through all of the files that have changed since Gecko moved to Hg.

4 files shipped in Camino 2 need (mostly small) updates.  The two useful files we tried to ship in Camino 2 (but where Gecko ignored our nsIStringBundleOverride) are already shipped to be localized via ChromeML, via my patch from bug 457290.

There are also a couple of forked files that localizers will need to update (e.g. appstrings.properties), but since they're forked, we updated the .strings.in files in the repo when we made the code changes.

I'd like to see if someone has a personal cert to check out the use-case for filepicker.properties (see the note on the wiki page about that file), if we have a chance.

But, so far, so good; the updates don't look too onerous to l10n.

What's left:

There are 2 dozen .properties files that haven't had contents changed since Hg.  All need to be audited again to ensure that 

a) if they're newly-shipped by our move to toolkit chrome, they're not used by Camino, or 

b) if they're files we looked at before for Camino 2, no new usages of said files have been added in Gecko code used by Camino.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Updates!

(In reply to comment #4)
> 4 files shipped in Camino 2 need (mostly small) updates.

I updated these by diffing the 1.9.2 Gecko file against the 1.9.0 Gecko file and pasting in the changed key names/values (for changed strings), or by pasting the whole block and doing my old find/replace magic to format new strings as Cocoa strings (for new strings).

I additionally made the s/plugin/plug-in/g changes in plugins_properties.strings.in (and title-cased the in-page page title).

> I'd like to see if someone has a personal cert to check out the use-case for
> filepicker.properties (see the note on the wiki page about that file), if we
> have a chance.

Turns out smfr wrote our own impl of personal cert stuff (the one place I could tell that that file was used), so…
 
> a) if they're newly-shipped by our move to toolkit chrome, they're not used
> by Camino, or 

There was one of these; I copied the Gecko file to the appropriate foo_properties.strings.in and ran my find/replace magic to transform it into Cocoa strings format, then made the associated Makefile and project changes.  I built and verified the override worked.

> b) if they're files we looked at before for Camino 2, no new usages of said
> files have been added in Gecko code used by Camino.

There were none of these.

Sadly, making all of the changes to make the patch took only a miniscule fraction of the time it took to wade through the dozens of files and their usage locations :P 

(I did make philor happy by discovering one completely unused file that he still hadn't managed to remove from mozilla-central, though ;) )

Comment 6

[Stuart Morgan]

Comment on attachment 540292 [details] [diff] [review]
Updates!

Review of attachment 540292 [details] [diff] [review]:
-----------------------------------------------------------------

sr=smorgan. Thanks for slogging through this stuff again!

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/1627db307956