553152 - Placeholder to work-around bug 552596 (can't set integer prefs) if necessary

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I filed bug 552596 on the fact that Toolkit does some very non-embedding-friendly stuff[1] in about:config to ensure integer prefs are set with integers (for some reason, they didn't port the code from XPFE, which worked and was embedding-friendly[2]).

Ideally that bug gets fixed--which probably means we fix it--though I'm not hopeful about branch chances in any case.  If it doesn't or doesn't make branch, we have to fork the file and either 1) regress the ability to ensure integer prefs are set as integers or 2) integrate the XPFE code into our fork of the toolkit version ourselves.

[1] http://mxr.mozilla.org/mozilla1.9.2/source/toolkit/components/viewconfig/content/config.js#594

[2] http://mxr.mozilla.org/mozilla/source/xpfe/global/resources/content/config.js#598

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

So, what happened here is that I fixed Toolkit on the trunk by doing option 2 and "restoring" the working XPFE code.  Unfortunately, it's not branchable like that because the strings are gone (never existed in Toolkit); branch options are 

a) back out integer validation entirely (seems like not-a-win), or
b) do some sort of app-specific #ifdefs (no clue even how to do that in JS, and ugly and unpalatable even if possible).

So I think the right thing to do here is c) have us fork the file for 1.9.2, since it's fixed going forward.  

I'll also add a note in the jar manifest to remove the fork on G>1.9.2 and a note in the properties.strings.in file to not remove those strings when updating Gecko strings files for 1.9.2.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Sticks a fork in the file

The JS has already been reviewed in bug 552596 (and in bug 254434 before that, when it was originally added to XPFE), so really just looking for approval of the forking and of my comments in the other two files ;)

Comment 3

[Stuart Morgan]

Comment on attachment 452981 [details] [diff] [review]
Sticks a fork in the file

sr=smorgan

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/bcec097daed8