553157 - accessibility problems caused by bug 347930

Status: RESOLVED INCOMPLETE

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Dao, please describe your patch changes (UI and interface changes) so we can realize what should be fixed in accessibility module.

Comment 1

[Dão Gottwald [:dao]]

The UI changes are pretty straightforward and you seemed to be aware of them yesterday, so I'm not sure what I'm expected me to add. <tabs> is now inside a <toolbar> rather than <tabbrowser>. There are no interface changes.

Comment 2

[alexander :surkov (:asurkov)]

Where (In reply to comment #1)
> The UI changes are pretty straightforward and you seemed to be aware of them
> yesterday, so I'm not sure what I'm expected me to add.

I know tabbrowser was excluded from tabs and tabpanels hierarchy. Therefore I'm asking to ensure there are other changes.

> <tabs> is now inside a
> <toolbar> rather than <tabbrowser>.

where are tabpanels elements? Don't we expect any more the "tabs" element and "tabpanels" element placed either inside an tabbox or tabbrowser? Is it neccessary to use "tabpanels" element? What's the current hierarchy?

> There are no interface changes.

I meant are there interface implementation changes by XBL bindings?

Were aria- properties used in tabbrowser XBL binding content?

Comment 3

[Dão Gottwald [:dao]]

We don't expect <tabs> to be inside <tabbox> anymore, that's correct. <tabbox> by default looks for <tabs> inside of itself, but if you override the 'tabs' property, you can make it point anywhere else.

<tabpanels> is where it used to be (inside <tabbox>, which is inside <tabbrowser>).

No aria- properties have been added or removed.

Comment 4

[alexander :surkov (:asurkov)]

Ok, thanks.

How can we find <tabs> from <tabpanels> and <tabpanels> from <tabs>? What interface or attributes we can use?

(In reply to comment #3)

> No aria- properties have been added or removed.

Ok, but do these bindings have them? Or role attribute? If bindings have then attributes might be subject to change.

Comment 5

[alexander :surkov (:asurkov)]

Is tabbrowser or tabbox inside it visual or do they have associated label or tooltips? I just don't get where bug 552964 comes from.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #4)
> How can we find <tabs> from <tabpanels> and <tabpanels> from <tabs>? What
> interface or attributes we can use?

<tabs> has the 'tabbox' property, which has the 'tabpanels' property. In order to go from <tabpanels> to <tabs>, you need to find <tabbox> first by iterating over <tabpanels>' parent nodes. <tabbox> then has a 'tabs' property.

(In reply to comment #5)
> Is tabbrowser or tabbox inside it visual or do they have associated label or
> tooltips? I just don't get where bug 552964 comes from.

I guess <tabs> is now announced because it isn't anonymous anymore.

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)
> (In reply to comment #4)
> > How can we find <tabs> from <tabpanels> and <tabpanels> from <tabs>? What
> > interface or attributes we can use?
> 
> <tabs> has the 'tabbox' property, which has the 'tabpanels' property. In order
> to go from <tabpanels> to <tabs>, you need to find <tabbox> first by iterating
> over <tabpanels>' parent nodes. <tabbox> then has a 'tabs' property.

We can't use XBL properties until they are part of interface if nothing was changed. The search shows they aren't part of any interface (http://mxr.mozilla.org/mozilla/search?string=tabbox&find=idl). Suggestions?

Comment 8

[Dão Gottwald [:dao]]

Maybe we can just add such an interface?

You searched on the wrong tree, btw... mozilla instead of mozilla-central.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to comment #8)
> Maybe we can just add such an interface?

It should be worth approach until we have other way.

> You searched on the wrong tree, btw... mozilla instead of mozilla-central.

yep, thanks

Comment 10

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #9)
> (In reply to comment #8)
> > Maybe we can just add such an interface?
> 
> It should be worth approach until we have other way.

Bug filed?

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Maybe we can just add such an interface?
> > 
> > It should be worth approach until we have other way.
> 
> Bug filed?

I think that's what bug 552944 is about.

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

Please reopen if needed.