Closed Bug 553267 Opened 10 years ago Closed 10 years ago

Allow specifying that you don't want flag data, for config.cgi

Categories

(Bugzilla :: Bugzilla-General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 3.4

People

(Reporter: mkanat, Assigned: mkanat)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since getting flag info is slow (bug 553266, which probably won't be fixed on branches) and it's also a lot of data to send over the wire, consumers of config.cgi should have the option to not get flag data if they don't want it.
Attached patch v1Splinter Review
Okay, flags are definitely the culprit for the performance problem. Setting "flags=0" makes config.cgi literally 10 times faster on my local copy of bmo. (It goes from 9.992s to 0.965s.)

  This adds the option to specify "flags=0" so that you don't get the flag info.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #433325 - Flags: review?(gerv)
Comment on attachment 433325 [details] [diff] [review]
v1

Looks good to me. r=gerv.

Gerv
Attachment #433325 - Flags: review?(gerv) → review+
  Taking on the branches as a workaround for bug 553266.
Blocks: bz-clients
Flags: approval3.6+
Flags: approval3.4+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified config.cgi
modified template/en/default/config.rdf.tmpl
Committed revision 7074.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified config.cgi
modified template/en/default/config.rdf.tmpl
Committed revision 7039.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.4/
modified config.cgi
modified template/en/default/config.rdf.tmpl
Committed revision 6751.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.