When flushing we need to flush external documents too

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 433379 [details] [diff] [review]
patch

When flushing documents we need to flush external documents too. For example, references to svg filters in external documents need their frames constructed for the filter to work. This only causes a problem with lazy frame construction.
(Assignee)

Updated

8 years ago
Attachment #433379 - Flags: review?(bzbarsky)
Comment on attachment 433379 [details] [diff] [review]
patch

r=bzbarsky.  Document in the presshell that we want this flush even if a presshell-only flush is being done (which is why the code is not just in nsDocument::FlushPendingnotifications)?
Attachment #433379 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

8 years ago
How does this sound?

    // We need to make sure external resource documents are flushed too (for
    // example, svg filters that reference a filter in an external document
    // need the frames in the external document to be constructed for the
    // filter to work). We only need external resources to be flushed when the
    // main document is flushing >= Flush_Frames, so we flush external
    // resources here instead of nsDocument::FlushPendingNotifications.
(Assignee)

Comment 3

8 years ago
Pushed with that comment
http://hg.mozilla.org/mozilla-central/rev/761790684f3b
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

8 years ago
Backed out for suspicion of causing tsvg_opacity regression
http://hg.mozilla.org/mozilla-central/rev/47ef6d724773
http://hg.mozilla.org/mozilla-central/rev/bfc8c8a40286
The regression was still there after backing this out, so it wasn't this bug. So I should be able to reland this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

8 years ago
Relanded this and the talos numbers were good.
http://hg.mozilla.org/mozilla-central/rev/35f66b11ec8b
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.