553371 - Overlapping text on plugin crash UI

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Tony Chung [:tchung]]

Attachment: plugin crash overlapping text screenshot

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100318 Minefield/3.7a4pre

In the plugin crash UI, there is overlapping text in the bottom right corner.  See screenshot

Repro:
1) download nightly with ipc enabled
2) Visit a webpage with the plugin running (eg. http://www.ncaa.com/home/)
3) open and crash a plugin (flash plugin)
4) Verify plugin UI has overlapping text in the bottom right.

Expected:
- window should size correctly to view text

Comment 1

[Justin Dolske [:Dolske]]

It seems to be displaying both the "Send crash report" and "No report available" messages, which is bizarre. Are you clicking the "Send crash report" at some point in the STR?

The only way I see for both strings to be shown at the same time is if the UI is initially showing the "No report available", and is then notified that a report was submitted... It unhides the "report submitted" text, but doesn't change the visibility of the "no report available" text because it shouldn't ever be visible at that point!

I can't reproduce this on my Windows 7 box.

Comment 2

[Tony Chung [:tchung]]

yes, i clicked the send crash report in the notification bar after the crash.  sorry for missing that major detail!

Comment 3

[Benjamin Smedberg]

"Open and crash a plugin" means what? Did you actually visit a site which reliably crashes flash, or did you kill mozilla-runtime from the process manager?

Comment 4

[timeless]

fwiw, the actual messages seem to be "Submission failed" and "No report available" :)

Comment 5

[Benjamin Smedberg]

This happens specifically when there is no crash report (e.g. killing mozilla-runtime using the task manager). The real bug here is that the notification bar has a "submit a crash report" button when there is no crash report ID to submit.

Comment 6

[Tony Chung [:tchung]]

(In reply to comment #3)
> "Open and crash a plugin" means what? Did you actually visit a site which
> reliably crashes flash, or did you kill mozilla-runtime from the process
> manager?

no, i visited the url above, streamed the ncaa tourney on flash for awhile, and watched it crash and throw up the crash UI with the notification bar.   Then submitted the crash report via the notification bar, and got this UI.   but it sounds like you found the culprit.

Comment 7

[Tony Chung [:tchung]]

(In reply to comment #5)
> This happens specifically when there is no crash report (e.g. killing
> mozilla-runtime using the task manager). The real bug here is that the
> notification bar has a "submit a crash report" button when there is no crash
> report ID to submit.

yep, confirming this. i did not get a crash report returned after submission.  (nothing in about:crashes)

Comment 8

[Justin Dolske [:Dolske]]

Ah! Yes, the problem as bsmedberg describes in comment 5. I can reproduce the issue now.

Comment 9

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Suppress the send report button when there's no minidump.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 434394 [details] [diff] [review]
Patch v.1

You could leave submitButton inside the ifdef, right? I'd also leave refreshButton as just an object literal to avoid having to push() it.

Comment 11

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Fixed. The object literal + push switches the button order, but I don't think that matters.

Comment 12

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/386f417ef8a8

Comment 13

[Benjamin Smedberg]

http://hg.mozilla.org/projects/firefox-lorentz/rev/d793cd544754

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed

Comment 15

[Benjamin Smedberg]

Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430