553485 - need a message displaying when no addons are found

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Tony Chung [:tchung]]

When there are no addons returned via search, we need to display a message in the body saying that.  Currently, there is nothing shown.

Repro:
1) install addons branch build: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6;
en-US; rv:1.9.3a3pre) Gecko/20100318 Minefield/3.7a3pre
2) open addons manager
3) search for something that wont return (eg. dflk;jsadfkl)
4) Verify there is no message saying "no matching add-ons" or something along that line. 

Expected:
- a "no matching add-ons" message returned if nothing is found.

Actual:
- blank.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Also needed this when there were no installed addons in a given category. Note that bug 553483 is related, but doesn't apply to all categories - for instance, if no addons are installed, we do still want to show the "Features" category.

http://hg.mozilla.org/projects/addonsmgr/rev/8c2ef649d47e

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Followup rev - forgot the strings.
http://hg.mozilla.org/projects/addonsmgr/rev/8811cb8b019b

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot of implemented message

Boriss: comments?

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot of implemented message (search)

Comment 5

[Dave Townsend [:mossop]]

Landed on trunk as a part of bug 554007

Comment 6

[Jennifer Morrow [:Boriss] (UX)]

This is fine for now; removing uiwanted

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Jennifer, shouldn't we show dots at the end of those messages? I miss those for various strings.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Blair, do we have automated tests meanwhile for this particular bug? Was it part of your final ui patch? Would we still need a Litmus test?

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101203 Firefox/4.0b8pre ID:20101203030309

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

The look of the message changed with 601022, but nothing functional changed. I believe we already had adequate automated tests for this.