553599 - Untagged images should get sRGB assignement

Status: REOPENED

(Core :: Graphics: Color Management, defect)

Description

[Paul-Kenji Cahier]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100316 Firefox/3.7a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100316 Firefox/3.7a1pre

There should either be a profile or a default process to assign sRGB to untagged images on the web, as those should be assumed to be sRGB. Trusting the operating system to display untagged images properly is fairly wrong as both Windows Vista and Windows 7 will incorrectly try to assign the monitor profile to untagged pictures. The same seems to be done on Mac OS X, and the result of that mess is that people with non sRGB monitor profiles get incorrect image display.

Please note that for this issue to be noticeable you will need:
1.An untagged picture
2.A monitor with a non sRGB profile(usually a calibrated monitor)

Ideally a preference would allow to set the default profile to be assigned to untagged.

Reproducible: Always

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Setting gfx.color_management.mode to 1 should do this.

See http://kb.mozillazine.org/Gfx.color_management.mode

Comment 2

[Bas Schouten (:bas.schouten)]

There's no plans currently to change the default.

Comment 3

[Benoit Girard (:BenWa)]

I talked to Jeff. This is something we should do but we don't because of performance. This is why this is on a pref.

Comment 4

[paperboyo]

I think there may be a regression in this as untagged imagery isn’t assumed to be sRGB in Firefox 77 (20200527121107) & 78.0a1 (20200528032513) on Windows 10 with gfx.color_management.mode set to 1. I’m sure it was always working. Please let me know if it’s preferable to open a new bug or if it’s a known (temporary) issue (maybe related to this?). I’ve tried all kinds of ICC display profiles which work in eg Chrome or Photoshop.

Steps to reproduce:
Preferably on a wide gamut monitor (but any straying from sRGB will do), display the same image untagged and tagged with sRGB profile next to each other. Alternatively visit https://www.theguardian.com/uk (where images are tagged) and https://www.nytimes.com/ (where they are not) and compare how they look in Firefox and eg Chrome.

Comment 5

[paperboyo]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)

Setting gfx.color_management.mode to 1 should do this.

See http://kb.mozillazine.org/Gfx.color_management.mode

Hello, Jeff, Andrew (sorry for tagging). This doesn’t seem to work for me (see above comment). Can you reproduce? Should I open a new bug?

Comment 6

[paperboyo]

Details for the above: Win 10 1909 (18363.836), NVidia RTX 2070 Driver 446.14.

Comment 7

[Nicos Gollan]

(In reply to paperboyo from comment #5)

This doesn’t seem to work for me (see above comment). Can you reproduce? Should I open a new bug?

That seems to be a regression in FF77, I filed an issue.: https://bugzilla.mozilla.org/show_bug.cgi?id=1643417

Comment 8

[paperboyo]

Thank you, Nicos!

Comment 9

[Nick Doyle]

jrmuizel, after our conversation on Friday, I believe this bug should be reopened.

To recap the situation today:

• Most displays today are now wide gamut; sRGB displays are becoming increasingly rare. This means all untagged images are displayed incorrectly.
• To get consistent accurate colour, every image needs to attach an ICC profile that is ~0.5KiB just so that Firefox hits the colour correct code path. This has both performance and bandwidth implications and adds up tremendously at (CDN) scale.

A good test case can be found here: https://kornel.ski/en/color

Comment 10

[Jeff Muizelaar [:jrmuizel]]

We talked about this today in our daily meeting and agreed that this is the right thing to do. I added two dependencies that we'll need to fix first, but we should be able to do this soon.