various fixes for nsChildView, including uninitialized member pointer

RESOLVED FIXED

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
All
Mac OS X
Points:
---

Firefox Tracking Flags

(status1.9.2 .7-fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Created attachment 433640 [details] [diff] [review]
fix v1.0
Attachment #433640 - Flags: review?
(Assignee)

Comment 1

8 years ago
Created attachment 433642 [details] [diff] [review]
fix v1.0 for 1.9.2
(Assignee)

Updated

8 years ago
Attachment #433640 - Flags: review? → review?(roc)
(Assignee)

Comment 2

8 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/1cce6e1d3089
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> Created an attachment (id=433642) [details]
> fix v1.0 for 1.9.2

This patch is not effective in getting rid of the warnings
listed at https://bugzilla.mozilla.org/show_bug.cgi?id=527280#c40,
iow, even with it we are still passing junk to flashplayer.
(Assignee)

Comment 4

8 years ago
This patch wasn't meant to fix that. That'll be taken care of elsewhere.
(Assignee)

Updated

8 years ago
Attachment #433642 - Flags: approval1.9.2.3?
Comment on attachment 433642 [details] [diff] [review]
fix v1.0 for 1.9.2

Approved for 1.9.2.6, a=dveditz
Attachment #433642 - Flags: approval1.9.2.4? → approval1.9.2.6+
(Assignee)

Comment 6

8 years ago
pushed to mozilla-1.9.2

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e60e42eabac0
status1.9.2: --- → .6-fixed
You need to log in before you can comment on or make changes to this bug.