553756 - password and passphrase have trouble staying in sync on two machines/ need UX improvements to getting a second system using new credenticals.

Status: RESOLVED DUPLICATE of bug 545725

(Firefox :: Sync, defect)

Description

[chris hofmann]

have one system set up and I'll call that "the master"

have another system set up and I'll call that "the slave"

1. change the password and passphrase on the master

2. on the slave I try and connect by clicking on the status bar and context selection for "connect".   -- result is status bar updates to show "Not signed in"
This is the correct status, but seems like better UX  would be to pop up a password/passphrase dialog.

3. If I select weave status bar icon, then pick "preferences"  I get the password dialog.  I can type in the new password and get connected.

4. I still haven't entered my new passphrase on the slave but for some reason I appear to able to perform sync'ing.  I wonder if it was really a valid sync, or how it could be with a sync with new key on the master, and never have entered the new key on the slave?  here is the log.

2010-03-19 23:56:07	Service.Main         DEBUG	Caching URLs under storage user base: https://sj-weave08.services.mozilla.com/1.0/chofmann/
2010-03-19 23:56:07	Service.Main         INFO	Logging in user chofmann
2010-03-19 23:56:07	Net.Resource         DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/info/collections
2010-03-19 23:56:49	Net.Resource         DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/meta/global
2010-03-19 23:56:49	Service.Main         DEBUG	Weave Version: 1.1 Compatible: 1.0rc4 Remote: 1.1
2010-03-19 23:56:49	Net.Resource         DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/info/collections
2010-03-19 23:56:49	Engine.Clients       INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:49	Engine.Clients       INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:49	Engine.Clients       DEBUG	Total (ms): sync 12, processIncoming 0, uploadOutgoing 11, syncStartup 1, syncFinish 0
2010-03-19 23:56:49	Engine.Bookmarks     INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:49	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/bookmarks?newer=1269036683.44&full=1&sort=index&limit=1500
2010-03-19 23:56:49	Engine.Bookmarks     INFO	Records: 0 applied, 11 reconciled, 0 left to fetch
2010-03-19 23:56:49	Engine.Bookmarks     DEBUG	Total (ms): sync 374, processIncoming 363, uploadOutgoing 1, syncStartup 1, syncFinish 0, createRecord 53, isEqual 55, reconcile 56
2010-03-19 23:56:49	Engine.Forms         INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:50	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/forms?newer=1269036687.19&full=1&sort=index&limit=1500
2010-03-19 23:56:50	Engine.Forms         INFO	Records: 5 applied, 2 reconciled, 0 left to fetch
2010-03-19 23:56:50	Engine.Forms         DEBUG	Total (ms): sync 405, processIncoming 374, uploadOutgoing 2, syncStartup 29, syncFinish 0, createRecord 0, isEqual 0, reconcile 0
2010-03-19 23:56:50	Engine.History       INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/history?newer=1269036710.72&full=1&sort=index&limit=1500
2010-03-19 23:56:51	Engine.History       INFO	Records: 73 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Collection           DEBUG	DELETE success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/history?ids=PkYzQiNaJa,QKoRV)!llc,evBpt.4gaS,ENKi2)m7FD,Kh6ao7SXYb,lPXWlF4p.H,JWrmWPCcai,4xFKBn*QDB,Z~gP6WMEN8,0r0)tI(U1…
2010-03-19 23:56:51	Engine.History       DEBUG	Total (ms): sync 1258, processIncoming 863, uploadOutgoing 1, syncStartup 0, syncFinish 356, findDupe 8, createRecord 20, isEqual 26, deleteId 0, handleDupe 6, reconcile 97
2010-03-19 23:56:51	Engine.Passwords     INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Engine.Passwords     INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Engine.Passwords     DEBUG	Total (ms): sync 2, processIncoming 1, uploadOutgoing 1, syncStartup 0, syncFinish 0
2010-03-19 23:56:51	Engine.Prefs         INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Engine.Prefs         INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Engine.Prefs         DEBUG	Total (ms): sync 1, processIncoming 1, uploadOutgoing 0, syncStartup 0, syncFinish 0
2010-03-19 23:56:51	Engine.Tabs          INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Store.Tabs           DEBUG	Adding remote tabs from chofmann's Firefox on 172
2010-03-19 23:56:51	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/tabs?newer=1269036711.9&full=1&sort=index&limit=1500
2010-03-19 23:56:51	Engine.Tabs          INFO	Records: 1 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Engine.Tabs          DEBUG	Total (ms): sync 420, processIncoming 419, uploadOutgoing 1, syncStartup 0, syncFinish 0, findDupe 0, reconcile 0
2010-03-19 23:56:51	Service.Main         INFO	Sync completed successfully

5. I restart firefox to begin a new session on the slave.  I get "not signed in status on the status bar.  I click on "status bar | connect" and it returns "Not Signed In"  on the status bar and  the following activity log

2010-03-19 23:56:07	Service.Main         DEBUG	Caching URLs under storage user base: https://sj-weave08.services.mozilla.com/1.0/chofmann/
2010-03-19 23:56:07	Service.Main         INFO	Logging in user chofmann
2010-03-19 23:56:07	Net.Resource         DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/info/collections
2010-03-19 23:56:49	Net.Resource         DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/meta/global
2010-03-19 23:56:49	Service.Main         DEBUG	Weave Version: 1.1 Compatible: 1.0rc4 Remote: 1.1
2010-03-19 23:56:49	Net.Resource         DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/info/collections
2010-03-19 23:56:49	Engine.Clients       INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:49	Engine.Clients       INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:49	Engine.Clients       DEBUG	Total (ms): sync 12, processIncoming 0, uploadOutgoing 11, syncStartup 1, syncFinish 0
2010-03-19 23:56:49	Engine.Bookmarks     INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:49	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/bookmarks?newer=1269036683.44&full=1&sort=index&limit=1500
2010-03-19 23:56:49	Engine.Bookmarks     INFO	Records: 0 applied, 11 reconciled, 0 left to fetch
2010-03-19 23:56:49	Engine.Bookmarks     DEBUG	Total (ms): sync 374, processIncoming 363, uploadOutgoing 1, syncStartup 1, syncFinish 0, createRecord 53, isEqual 55, reconcile 56
2010-03-19 23:56:49	Engine.Forms         INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:50	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/forms?newer=1269036687.19&full=1&sort=index&limit=1500
2010-03-19 23:56:50	Engine.Forms         INFO	Records: 5 applied, 2 reconciled, 0 left to fetch
2010-03-19 23:56:50	Engine.Forms         DEBUG	Total (ms): sync 405, processIncoming 374, uploadOutgoing 2, syncStartup 29, syncFinish 0, createRecord 0, isEqual 0, reconcile 0
2010-03-19 23:56:50	Engine.History       INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/history?newer=1269036710.72&full=1&sort=index&limit=1500
2010-03-19 23:56:51	Engine.History       INFO	Records: 73 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Collection           DEBUG	DELETE success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/history?ids=PkYzQiNaJa,QKoRV)!llc,evBpt.4gaS,ENKi2)m7FD,Kh6ao7SXYb,lPXWlF4p.H,JWrmWPCcai,4xFKBn*QDB,Z~gP6WMEN8,0r0)tI(U1…
2010-03-19 23:56:51	Engine.History       DEBUG	Total (ms): sync 1258, processIncoming 863, uploadOutgoing 1, syncStartup 0, syncFinish 356, findDupe 8, createRecord 20, isEqual 26, deleteId 0, handleDupe 6, reconcile 97
2010-03-19 23:56:51	Engine.Passwords     INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Engine.Passwords     INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Engine.Passwords     DEBUG	Total (ms): sync 2, processIncoming 1, uploadOutgoing 1, syncStartup 0, syncFinish 0
2010-03-19 23:56:51	Engine.Prefs         INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Engine.Prefs         INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Engine.Prefs         DEBUG	Total (ms): sync 1, processIncoming 1, uploadOutgoing 0, syncStartup 0, syncFinish 0
2010-03-19 23:56:51	Engine.Tabs          INFO	0 outgoing items pre-reconciliation
2010-03-19 23:56:51	Store.Tabs           DEBUG	Adding remote tabs from chofmann's Firefox on 172
2010-03-19 23:56:51	Collection           DEBUG	GET success 200 https://sj-weave08.services.mozilla.com/1.0/chofmann/storage/tabs?newer=1269036711.9&full=1&sort=index&limit=1500
2010-03-19 23:56:51	Engine.Tabs          INFO	Records: 1 applied, 0 reconciled, 0 left to fetch
2010-03-19 23:56:51	Engine.Tabs          DEBUG	Total (ms): sync 420, processIncoming 419, uploadOutgoing 1, syncStartup 0, syncFinish 0, findDupe 0, reconcile 0
2010-03-19 23:56:51	Service.Main         INFO	Sync completed successfully

Again, we should put up the password/passphrase dialog for this kind of failure, but it also seems like it should have cached my password from the previous session.

6.  Select "Weave on status bar | preferences"  and then I get the the "Wrong Secret Phrase" dialog.

In some tests runs though the sequence of steps 5 and 6 my new pass passphrase seem to be rejected.  It was only after I selected the "reset passphrase" and got an extra passphrase resent dialog that I was able to get pass the "wrong secret phrase" message, but this appears to be unreproducible.

In other test runs you can just enter the new passphrase, have it accepted and you are finally on your way to getting syncing going again on the slave.

I think there are both some bugs, and UX improvements to be made to running through the test sequence above where you change the credentials on one system, and get prompted to change them, and start using them, on the second system in one easy step on the second system.

Comment 1

[Ed Lee :Mardak]

Seems related to bug 553398 where clicking Connect doesn't give feedback on failure except in this case the passwords are wrong instead of missing.

Comment 2

[chris hofmann]

Attachment: wrong passphrase dialog from comment 6

Comment 3

[chris hofmann]

I also wonder if there is a possible leak of info in step 4 when it appeared I could access weave data on the server using the old passphrase after the new passphrase should be in effect.

should we have some kind of semaphore in effect where after the entry of the new passphrase we lock the server from access by other clients under that account until a new sync from the master has been completed?  then it seams like slave clients would fail on syncing until they entered the new credenticals.

I guess this maybe starting to become more of a meta bug that we spin off other related bugs and test cases around interactions between to clients and the server.

Comment 4

[chris hofmann]

when making a test case out of the 6 steps above one addition could be to do a check of the password manager to see if the weave password and passphrase were both in the expected state after each step.  If there any other ways to examine internal caches of the password and passphrase that would be a good check as well.

Comment 5

[chris hofmann]

one way to measure how serious a problem this is would be to look at the number of failed sync's, failed logins, and failed passphrase errors we are detected.

 "DEBUG	Exception: Login failed: error.login.reason.passphrase No traceback available"

appears to indicate the passphrase inconsistency between clients.

Comment 6

[Mike Connor [:mconnor]]

This is sort of a "a bunch of stuff is wrong" bug.

First, most of this bug is just a dupe of bug 545725.  Once we're doing regen key, wipe server and re-upload re-encrypted data, there won't be an ambiguous state.

if you're not getting an error indication on the statusbar, or the message isn't clear, please file a bug on that.  There's a bug about combining notifications and the statusbar UI, which may morph to killing the default statusbar UI, and enhancing the notifications given.

Popping a modal prefwindow is fine if there's a user-initiated action along with that, but I don't think we want to immediately prompt on failure.  That should be a separate bug (show pw/pp UI as needed if manual login attempt fails).

I'm going to mark this as a dupe, but please file the separate issues that aren't covered in what needs to be done with 545725.

Comment 7

[chris hofmann]

(In reply to comment #6)
> This is sort of a "a bunch of stuff is wrong" bug.
> 

yeah, maybe.  It's a single task (i'm trying to get a new pass phrase set up on both of my clients) with a bunch of problems.  that's what meta bugs are about.  I think to fix the problems outlined in this bug we need to fix both of the problems that edilee added as dependence bugs.  when those are fixed we can problem figure out if there are more bugs lurking.