Linux debug tests not running

RESOLVED FIXED

Status

Release Engineering
General
P1
blocker
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: philor, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Since somewhere between the Friday 5am push and the 9am push to mozilla-central, the Linux debug tests disappeared. Since that means no leak tests, the tree is closed.

I'm a bit suspicious of http://hg.mozilla.org/build/buildbot-configs/rev/9da583f2c2e2#l2.61 since that certainly appears to make the default for Linux debug to not run tests. I think that's probably misplaced, intended for the linux64-debug block below, which doesn't have a default with either value for enable_unittests.
(Assignee)

Updated

8 years ago
Assignee: nobody → nrthomas
Priority: -- → P1
(Assignee)

Comment 1

8 years ago
Created attachment 433702 [details] [diff] [review]
Quick fix

As philor spotted, there was an error in where the False was applied. This fixes that up, and also makes some ordering changes to the staging config so that it's easier to diff this section of the code against produciton. Turns out we had it right in staging but not production when the change first landed in 9da583f2c2e2.

http://hg.mozilla.org/build/buildbot-configs/rev/910bbd48c94e
Attachment #433702 - Flags: review?(catlee)
Attachment #433702 - Flags: checked-in+
(Assignee)

Comment 2

8 years ago
pm01/02 reconfiged. Triggered m-c and tracemonkey builds to verify the fix.
(Assignee)

Comment 3

8 years ago
Tests are running, tree reopened.
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Comment on attachment 433702 [details] [diff] [review]
Quick fix

rubber stamp applied
Attachment #433702 - Flags: review?(catlee) → review+
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.