553769 - Linux debug tests not running

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Phil Ringnalda (:philor)]

Since somewhere between the Friday 5am push and the 9am push to mozilla-central, the Linux debug tests disappeared. Since that means no leak tests, the tree is closed.

I'm a bit suspicious of http://hg.mozilla.org/build/buildbot-configs/rev/9da583f2c2e2#l2.61 since that certainly appears to make the default for Linux debug to not run tests. I think that's probably misplaced, intended for the linux64-debug block below, which doesn't have a default with either value for enable_unittests.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Quick fix

As philor spotted, there was an error in where the False was applied. This fixes that up, and also makes some ordering changes to the staging config so that it's easier to diff this section of the code against produciton. Turns out we had it right in staging but not production when the change first landed in 9da583f2c2e2.

http://hg.mozilla.org/build/buildbot-configs/rev/910bbd48c94e

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

pm01/02 reconfiged. Triggered m-c and tracemonkey builds to verify the fix.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Tests are running, tree reopened.

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 433702 [details] [diff] [review]
Quick fix

rubber stamp applied